Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editor discard prompt #2990

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

Zouizoui78
Copy link
Contributor

Description
Currently the editor changes discard prompt is bugged and appears in the following two situations where it should not:

  • when the file is empty, like right after its creation
  • after the file has been saved

This PR aims to solve both issues.

馃毃 Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • AVOID breaking the continuous integration build.

@Zouizoui78
Copy link
Contributor Author

I changed my commit a bit (forced pushed because of a mistake on my part) to make use of the logic that is already implemented by ace to know if the editor is dirty or not.

@o1egl o1egl merged commit 34a0817 into filebrowser:master Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants