Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fs.fdatasync() #653

Open
humphd opened this issue Jan 3, 2019 · 2 comments
Open

Add support for fs.fdatasync() #653

humphd opened this issue Jan 3, 2019 · 2 comments

Comments

@humphd
Copy link
Contributor

humphd commented Jan 3, 2019

https://nodejs.org/api/fs.html#fs_fs_fdatasync_fd_callback

@modeswitch
Copy link
Member

Is this for compatibility reasons only? According to the docs it's possible for a transaction to report completion before data is flushed to physical storage. There's also no standardization (I think?) between implementations around this behavior. Firefox uses a non-standard API to allow client code to force flushing before completion.

@humphd
Copy link
Contributor Author

humphd commented Apr 7, 2019

Only for compat, yes, it will be essentially a no-op.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants