Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] vcpkg template is used incorrectly #34

Open
vadi2 opened this issue Jan 22, 2022 · 3 comments
Open

[BUG] vcpkg template is used incorrectly #34

vadi2 opened this issue Jan 22, 2022 · 3 comments
Assignees
@filipdutescu
Labels
acknowledged The issue is being worked on bug Something isn't working

Comments

@vadi2
Copy link
Contributor

vadi2 commented Jan 22, 2022

Just the vcpkg.cmake file is being downloaded, however that is not the correct way to use vcpkg, see microsoft/vcpkg#22690.
@vadi2 vadi2 added the bug Something isn't working label Jan 22, 2022
@ras0219-msft
Copy link

I'd recommend using FetchContent instead to grab the entire vcpkg repo. This must be done before the project() directive, since vcpkg integration is via CMAKE_TOOLCHAIN_FILE which is loaded during project().

@filipdutescu filipdutescu self-assigned this May 17, 2022
@filipdutescu filipdutescu added the acknowledged The issue is being worked on label May 17, 2022
@filipdutescu
Copy link
Owner

Nice catch! Thanks for submitting it and providing some guidance as well. Will work on a fix and create a release ASAP.

@Milerius
Copy link

is that addressed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipdutescu filipdutescu

Labels
acknowledged The issue is being worked on bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vadi2 @ras0219-msft @Milerius @filipdutescu