Add simple test for generic FieldRenderProps type

[Andarist]

No description provided.

[codecov]

Codecov Report

Merging #439 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #439   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     10    -5     
  Lines         235    210   -25     
  Branches       58     62    +4     
=====================================
- Hits          235    210   -25

Impacted Files	Coverage Δ
src/FormSpy.js	100% <0%> (ø)	⬆️
src/ReactFinalForm.js	100% <0%> (ø)	⬆️
src/Field.js	100% <0%> (ø)	⬆️
src/useField.js
src/useFormState.js
src/useForm.js
src/useConstant.js
src/useWhenValueChanges.js
src/flattenSubscription.js
src/testUtils.js
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7315a3a...9c5cdad. Read the comment docs.

[erikras]

This pull request introduces 2 alerts when merging 1e1d5fe into a3ca5f1 - view on LGTM.com

new alerts:

• 2 for Unused variable, import, function or class

---

Comment posted by LGTM.com

[erikras]

This pull request introduces 2 alerts when merging 0697fd6 into a3ca5f1 - view on LGTM.com

new alerts:

• 2 for Unused variable, import, function or class

---

Comment posted by LGTM.com

[erikras]

Can't ts-essentials be a dev dependency?

[Andarist]

Not rly, because the imported thing would have to be inlined during build, but .d.ts files are distributed as is (building them anyhow when the source is not authored in TS would be a huge overkill).

We could inline manually this implementation, but personally I find it counter-productive.

[erikras]

I'm correct in assuming that we could add a hundred different type helper libs as dependencies, and it would have no effect whatsoever on the final bundle size the browser sees, because TS is entirely build-time, right?

[vladshcherbin]

@erikras I believe this is partly correct, adding TS packages to dependencies will install unnecessary packages for devs who are not using TS (types won't be bundled in browser build though).

This is what I found out when tried to add types to one of my packages. For js projects, adding types to @types repo is a much better solution and is recommended in TS docs.

[erikras]

This pull request introduces 2 alerts when merging 9c5cdad into 7315a3a - view on LGTM.com

new alerts:

• 2 for Unused variable, import, function or class

---

Comment posted by LGTM.com

[erikras]

Published in v5.1.1.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.