Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field type prop not injected to input #471

Closed
doguh opened this issue May 15, 2019 · 4 comments · Fixed by #472
Closed

Field type prop not injected to input #471

doguh opened this issue May 15, 2019 · 4 comments · Fixed by #472

Comments

@doguh
Copy link

doguh commented May 15, 2019

Hi,

first time using this lib, seems really nice but I encountered an issue after 5 minutes of testing with the latest build (5.0.0 and 5.0.1 on npm)

Are you submitting a bug report or a feature request?

a bug

What is the current behavior?

the type prop of the Field component is not injected into the input

it seems to only work with radio and checkbox types but not with password

<Field type="password" /> results in <input />

What is the expected behavior?

<Field type="password" /> should result in <input type="password" />

Sandbox Link

Try to change any type="text" into type="password" in this example
https://codesandbox.io/s/6y4ny3xjr

What's your environment?

Windows 10, react-final-form 5.0.1, node 10.14

Other information

For your information, it works perfectly with react-final-form 4.1.0

@erikras
Copy link
Member

erikras commented May 15, 2019

Aha! I forgot about the other types. 🤦‍♂️

@erikras
Copy link
Member

erikras commented May 15, 2019

Published fix in v5.0.2.

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants