Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flattenSubscription hooks-safe #479

Merged
merged 1 commit into from
May 16, 2019

Conversation

Andarist
Copy link
Contributor

The simplest thing I could think of that would make flattenSubscription hooks-safe.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #479 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #479   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         233    235    +2     
  Branches       62     58    -4     
=====================================
+ Hits          233    235    +2
Impacted Files Coverage Δ
src/ReactFinalForm.js 100% <100%> (ø) ⬆️
src/useFormState.js 100% <100%> (ø) ⬆️
src/useField.js 100% <100%> (ø) ⬆️
src/flattenSubscription.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6054da7...a8f809b. Read the comment docs.

@erikras
Copy link
Member

erikras commented May 16, 2019

OOHHHH!!! The || was what you meant by not being "hooks safe". 🤦‍♂️

@erikras erikras merged commit 4e72442 into final-form:master May 16, 2019
@Andarist
Copy link
Contributor Author

@Andarist Andarist deleted the hooks-safe-flatten-subscription branch May 16, 2019 18:15
@erikras
Copy link
Member

erikras commented May 24, 2019

Published in v5.1.1.

@lock
Copy link

lock bot commented Jun 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants