Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak useFormState TS types #482

Merged
merged 1 commit into from
May 24, 2019
Merged

Tweak useFormState TS types #482

merged 1 commit into from
May 24, 2019

Conversation

Andarist
Copy link
Contributor

Fixes #476

@Andarist Andarist mentioned this pull request May 17, 2019
Closed
@codecov
Copy link

codecov bot commented May 17, 2019 •
edited

Codecov Report

Merging #482 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #482   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         235    235           
  Branches       58     58           
=====================================
  Hits          235    235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e72442...f46b46f. Read the comment docs.

@erikras
Copy link
Member

erikras commented May 17, 2019

This pull request introduces 2 alerts when merging f46b46f into 4e72442 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

Comment posted by LGTM.com

@erikras erikras merged commit cb45e47 into final-form:master May 24, 2019
@Andarist Andarist deleted the ts/tweak-use-form-state branch May 24, 2019 07:42
@erikras
Copy link
Member

erikras commented May 24, 2019

Published in v5.1.1.

@lock
Copy link

lock bot commented Jun 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useFormState has painful typescript return type
2 participants
@Andarist @erikras