Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form rerender bug #498

Merged
merged 1 commit into from
May 27, 2019
Merged

Fix form rerender bug #498

merged 1 commit into from
May 27, 2019

Conversation

erikras
Copy link
Member

@erikras erikras commented May 27, 2019

This is the proper fix for #487 and #492. Reverts #495.

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #498 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #498   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         229    231    +2     
  Branches       57     57           
=====================================
+ Hits          229    231    +2
Impacted Files Coverage Δ
src/ReactFinalForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b289b...adc5a1d. Read the comment docs.

@erikras erikras merged commit 38b9b00 into master May 27, 2019
@erikras erikras deleted the fix-form-rerender-bug branch May 27, 2019 09:55
@erikras
Copy link
Member Author

erikras commented May 27, 2019

Published in v6.0.0.

@lock
Copy link

lock bot commented Jun 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant