Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Types to make useField's options optional #499

Merged
merged 1 commit into from
May 28, 2019

Conversation

rockingskier
Copy link
Contributor

useField has a default value but the Types do not.

That means useField('name') throws an error in TS.

This PR make the options object optional.

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #499 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #499   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         231    231           
  Branches       57     57           
=====================================
  Hits          231    231

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13008e3...5970b74. Read the comment docs.

@erikras erikras merged commit d4f6ca8 into final-form:master May 28, 2019
@erikras
Copy link
Member

erikras commented May 29, 2019

Published in v6.0.1.

@lock
Copy link

lock bot commented Jun 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants