Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getContext back to a simple context file #524

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

Andarist
Copy link
Contributor

Followup to #516 (comment)

This types correctly. The gist is that you can have a context which contains a parametrized type with any type parameter and you just assign it to the left hand side with that "any" filled with concrete type.

@erikras
Copy link
Member

erikras commented Jun 11, 2019

This pull request introduces 1 alert when merging ba062c6 into 3dc413a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #524 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #524   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     15    -1     
  Lines         232    224    -8     
  Branches       57     55    -2     
=====================================
- Hits          232    224    -8
Impacted Files Coverage Δ
src/useForm.js 100% <ø> (ø) ⬆️
src/ReactFinalForm.js 100% <ø> (ø) ⬆️
src/FormSpy.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc413a...ba062c6. Read the comment docs.

@erikras erikras merged commit 9cd3343 into final-form:master Jun 14, 2019
@erikras
Copy link
Member

erikras commented Jun 14, 2019

Published in v6.2.0.

@lock
Copy link

lock bot commented Jul 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants