Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormSpy onChange and input type="radio" #569

Closed
bwlt opened this issue Jul 23, 2019 · 2 comments · Fixed by #572
Closed

FormSpy onChange and input type="radio" #569

bwlt opened this issue Jul 23, 2019 · 2 comments · Fixed by #572

Comments

@bwlt
Copy link
Contributor

bwlt commented Jul 23, 2019

Are you submitting a bug report or a feature request?

Bug report.

What is the current behavior?

Don't know why FormSpy onChange callback is called with a wrong FormRenderProps value reference

What is the expected behavior?

FormSpy onChange callback should be called with valid references

Sandbox Link

https://codesandbox.io/embed/hardcore-wind-4mgqt

What's your environment?

"final-form": "4.18.2"
"react": "16.8.4"
"react-dom": "16.8.4"
"react-final-form": "6.3.0"

Other information

It happens only with radio components
@erikras
Copy link
Member

erikras commented Jul 29, 2019

Wow! Great bug catch!

Thankfully, it happens with all components (not just radio).

@erikras erikras mentioned this issue Jul 29, 2019
Merged
@m4theushw m4theushw mentioned this issue Oct 27, 2019
Closed
@fzaninotto fzaninotto mentioned this issue Nov 15, 2019
Open
@erikras
Copy link
Member

erikras commented Nov 18, 2019

Published fix in v6.3.1.

@snyk-bot snyk-bot mentioned this issue Nov 28, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed FormSpy bug with ignoring changes to onChange final-form/react-final-form
2 participants
@erikras @bwlt