Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed FormSpy bug with ignoring changes to onChange #572

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

erikras
Copy link
Member

@erikras erikras commented Jul 29, 2019

Fixes #569.

@erikras erikras changed the title Fixed bug with ignoring changes to onChange Fixed FormSpy bug with ignoring changes to onChange Jul 29, 2019
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #572 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #572   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         231    233    +2     
  Branches       57     57           
=====================================
+ Hits          231    233    +2
Impacted Files Coverage Δ
src/useFormState.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae3eeca...e528305. Read the comment docs.

@erikras erikras merged commit 31b8f61 into master Jul 29, 2019
@erikras erikras deleted the FormSpy-onChange-bug branch July 29, 2019 11:05
@lock
Copy link

lock bot commented Aug 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
@erikras
Copy link
Member Author

erikras commented Nov 18, 2019

Published in v6.3.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormSpy onChange and input type="radio"
1 participant