Fix async act warning #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DO NOT MERGE without reading. This PR updates react to the new rc, and uses the new async act to silence a warning in ReactFinalForm.test.js Further, regarding Field.test.js, I rewrote `sleep` with `act`, and discovered some issues, and disabled some tests - 'should use isEqual to calculate dirty/pristine': This test goes into an infinite loop; it appears act() has caught an actual bug here. 'should `formatOnBlur` most updated value' and 'should pass multiple through to custom components' appear to be breaking some assumptions for react-dom, and should probably be fixed. I've included the warning messages that show for these warnings too.
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 233 233
Branches 57 57
=====================================
Hits 233 233Continue to review full report at Codecov.
|
|
I've noticed that you have broken my PR by merging master to it, so I've fixed it by merging master to it |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #578