removes Omit from the typescript definitions #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 233 233
Branches 57 57
=====================================
Hits 233 233Continue to review full report at Codecov.
|
|
@Andarist, this look 馃憤 to you? |
|
Yeah, sure - in the future you could replace it back with builtin Omit. Not sure if it's a great time right now to do it, but maybe once TS@3.6 gets out? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current typings depend upon
Omit<>from ts-essentials but this is a common type that has been added by people (myself included) to their projects. The duplicate definition ofOmit<>causes the compiler to complain.Omit<>has also been added to TS 3.5 so this will cause a conflict for those people who are targeting 3.5To work around this I have changed the use of the
Omit<>type helper and replaced it with the more explicit use ofPick<>andExclude<>. This will prevent anyone that has their own Omit<> type or is targeting TS 3.5 from failing to build the project.The added bonus is that ts-essentials is no longer needed so there is one less dependency required 馃樅. However I decided not to remove this from the
package.jsonas the reference tofinal-formis set as to use ayalclink. I do not have this setup so decided it is best left out of this PR.