RFC: pausing validation before unmount #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing serious performance problems on large forms, since validation is generally O(number_fields), and we'd be calling it number_fields times when running all the deregistrations.
|
Fantastic! 👍 |
|
Heh, alright. I hope you know what the useEffect semantics are better than I do 😅 |
|
I can confirm that effect disposers are run parent-first, at least experientially. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that with classes this should go in
componentWillUnmount(), but I'm not 100% clear on the semantics ofuseEffect(). Does it also run parent-first when a tree is being unmounted?If this does what I expect it to, will fix #408. Will make a test case before removing the RFC tag.