Fix issue with inline isEqual causing an infinite rerender loop #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
force-pushed
the
fix/inline-is-equal-infinite-loop
branch
from
45240e5
to
5056cf9
Compare
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 248 251 +3
Branches 57 58 +1
=====================================
+ Hits 248 251 +3
Continue to review full report at Codecov.
|
|
@erikras friendly 🏓 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #517
The same thing still happens for defaultValue & initialValue - but to fix those you'd have to decide what should happen when they change (IMHO nothing should happen, only first values should get registered).