Forward refs to input component

[TylerRick]

Resolves #141

Still to do:

• Make the same change to Field in react-final-form-html5-validation (Forward refs to input component react-final-form-html5-validation#18)
• Add a test
• Update docs
• Get Flow typings to work in Field.js

[TylerRick]

All right, I added a test for this. So now I think the main blocker is this flow error:

[flow] Missing type annotation for `Config`. `Config` is a type parameter declared in function type [1] and was implicitly
[flow] instantiated at call of method `forwardRef` [2].

I haven't used Flow before (I use TypeScript), so I wouldn't know how to fix this. Could someone lend a hand please? ✋

[ivchenkodima]

Any updates?

[kopax]

can we get this released? This is so much needed in react native for the user experience: https://stackoverflow.com/questions/32748718/react-native-how-to-select-the-next-textinput-after-pressing-the-next-keyboar

I don't need flow validation I don't use typescript, is there a fork I can use to get this working?

[kopax]

Someone really needs to kick this, it can't be a major fix and being stuck for soon a year.

[kopax]

Thanks @erikras for taking care of it, that is somehow super important and I appreciate you took care of our remarks. Do you think this will be released soon?

[erikras]

I hope so. Flow has been a real pain for the past couple of years, blocking solid PRs like this one. At some point, FF and RFF will need to be rewritten into Typescript and Flow support dropped.

[erikras]

@kopax In your opinion, does this merge alleviate the need for #781?

[kopax]

Yes, this was to push a little bit, I will close this PR, and also #779 as soon as we can test the new feature and validate it as fixed on our end.

[kopax]

It seems that the CI prevent the release of being done: https://travis-ci.org/github/final-form/react-final-form/jobs/676834260 , perhaps #141 should be kept open until it's done?

[kopax]

@erikras any update on that one? Perhaps it's possible to drop Flow type on just that file? Or at leaste release one version in a nighty channel?

[Nnanyielugo]

It doesn't seem like this release made it through. Is there a way this could be pushed through?
I had to use redux form for the one form that needed refs, and it seems a little too hackish.

Would be nice if this was looked into.

[kopax]

@Nnanyielugo this is the issue for tracking, #483

I am also expecting to see this soon, I was about to remove RFF before they merged this. Any plan for this ?

[erikras]

Apologies for the delay. Since this was merged, I gave two conference workshops, one conference talk, and started two new jobs. Publishing today...

[erikras]

Published in v6.5.0.

[kopax]

thanks for the release ! I would like to know if anyone have tested it ? Passing const ref = useRef(); to the <Field ref={ref} /> does not save the ref as I expect.

[SpadarShut]

@kopax I confirm, passing ref to Field does not set current to input, but instead sets it to the field instance. Using ReactDOM.

[SpadarShut]

Looks like the output of react-final-form-html5-validation.es.js does not contain the chenges from this PR.

[kopax]

Thanks for sharing, It's a problem if it use react dom because it won't work in react native.

What's the status of this @erikras Is this now fixed and from what versIon?