Fix typescript typings in FieldProps

[bwlt]

According to the doc the parse prop takes the value from the input (which is typed with FieldValue)

[codecov]

Codecov Report

Merging #619 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #619   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         248    248           
  Branches       57     57           
=====================================
  Hits          248    248

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3add0f3...d0d7604. Read the comment docs.

[erikras]

Published in v6.3.1.

[br0wn]

Hello. I ran into issue with this PR when I have different type of value in the input than that is stored in the form values. I get following error:

Type '(value: moment.Moment | undefined) => string | undefined' is not assignable to type '(value: Moment | undefined, name: string) => Moment | undefined'.
  Type 'string | undefined' is not assignable to type 'Moment | undefined'.
    Type 'string' is not assignable to type 'Moment | undefined'.

const parseDate = useCallback(
    (value: Moment | undefined) => value ? value.format('YYYY-MM-DD') : undefined,
    []
  );

interface FormValues {
  ...
  date?: string;
  ...
}

<Field
  name="date"
  allowNull={true}
  parse={parseDate}
  format={formatDate}
  render={render={({ input }) => (
    <DatePicker 
      value={input.value as any} 
      onChange={(value) => input.onChange({ target: { value } })}
    />
  )}
/>

My case converts Moment object to string, but it can be applied to the example from documentation as well:

parsing localized dates into actual javascript Date objects

Does the FieldValue typing represent the value of the field stored in the form or the value put into the input?

[Juansasa]

This fix broke everything for us.

We do use custom input and the data types used for the input does not necessary mean the form type.

Format: formType => inputType
Parse: inputType =>formType not formtype => formType it defeat the purpose of parsing in the first place.

Please fix this ASAP

[erikras]

I agree, @Juansasa.

[erikras]

Reverted in v6.3.3.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.