Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts] fix FormProps['decorators'] #629

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

zekchan
Copy link
Contributor

@zekchan zekchan commented Sep 17, 2019

This PR fixes Type 'Decorator<IValues>[]' is not assignable to type 'Decorator<object>[]'. error when decorator is typed with signature Decorator<IValues>

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #629 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #629   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         248    248           
  Branches       57     57           
=====================================
  Hits          248    248

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3add0f3...d67d4a7. Read the comment docs.

@zekchan
Copy link
Contributor Author

zekchan commented Oct 8, 2019

@erikras is it possible this PR to be merged?

@erikras erikras merged commit 3d9dfa2 into final-form:master Nov 7, 2019
@erikras
Copy link
Member

erikras commented Nov 18, 2019

Published in v6.3.1.

@lock
Copy link

lock bot commented Dec 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants