Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass FormValues type to Decorator #661

Merged
merged 2 commits into from
Oct 28, 2019

Conversation

sedx
Copy link
Contributor

@sedx sedx commented Oct 25, 2019

When from values are typed (suppose T) and we pass some decorators, instead Decorator<T>[] decorator prop's type resolves to Decorator<object>[].

So correctly typed decorators with correctly typed form process type error.

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #661 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #661   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         251    251           
  Branches       58     58           
=====================================
  Hits          251    251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692f1d1...89af6a8. Read the comment docs.

@sedx sedx force-pushed the Pass-form-values-type-to-decorator branch from a42b042 to 89af6a8 Compare October 25, 2019 16:24
@erikras erikras merged commit 0a3d9b8 into final-form:master Oct 28, 2019
@erikras
Copy link
Member

erikras commented Nov 18, 2019

Published in v6.3.1.

@lock
Copy link

lock bot commented Dec 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants