Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made lazy state getters enumerable #678

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Made lazy state getters enumerable #678

merged 1 commit into from
Nov 19, 2019

Conversation

erikras
Copy link
Member

@erikras erikras commented Nov 19, 2019

Fixes #677

Also fixes bug found by @onlyann here: #677 (comment)

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #678 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #678   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         251    251           
  Branches       58     58           
=====================================
  Hits          251    251
Impacted Files Coverage Δ
src/getters.js 100% <100%> (ø) ⬆️
src/renderComponent.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d02b1...a265bfa. Read the comment docs.

@erikras erikras merged commit 09bc4b9 into master Nov 19, 2019
@erikras erikras deleted the enumerable-state branch November 19, 2019 09:27
@erikras
Copy link
Member Author

erikras commented Nov 19, 2019

Published in v6.3.2.

@lock
Copy link

lock bot commented Dec 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.3.1 breaks autosave example
1 participant