Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit edge case fix #697

Merged
merged 3 commits into from
Dec 16, 2019
Merged

Conversation

gbiryukov
Copy link
Contributor

see #695

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #697 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #697   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         251    251           
  Branches       58     58           
=====================================
  Hits          251    251
Impacted Files Coverage Δ
src/useField.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add4fcf...387b22f. Read the comment docs.

@erikras
Copy link
Member

erikras commented Dec 16, 2019

Wow, what a very edgy case this is! 👍

I've changed your test to use the previously existing <Toggle/> component built for exactly this sort of test. 😄

@erikras erikras merged commit d90e418 into final-form:master Dec 16, 2019
@erikras
Copy link
Member

erikras commented Dec 16, 2019

Great PR, btw.

  • Test that demonstrates the bug ✅
  • Fix with lengthy comment explaining ✅

❤️

@lock
Copy link

lock bot commented Jan 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
@erikras
Copy link
Member

erikras commented Jan 22, 2020

Published in v6.3.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants