Improved type definition for Field #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use first generic argument in the default for second generic argument.
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 251 251
Branches 58 58
=====================================
Hits 251 251Continue to review full report at Codecov.
|
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Field's first generic argument in the default for second generic argument.
Here's an example (notice any vs Date):
Since the first generic argument already defaults to any, there's no need to set any in it's place in the second generic argument. This way, if a developer only sets the first generic argument of Field, they still get the input.value prop properly typed, instead of being any (current behavior). And if they omit it all together, it'll default to any, as it currently does.