Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handleSubmit typings #715

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Conversation

forivall
Copy link
Contributor

Fixes #86

The typescript typings work in my local code - in this case, with a button handler, but it should work in React Native typescript typings as well.

Let me know if the flow typings changes are fine - i did my best 馃槃 .

@forivall
Copy link
Contributor Author

forivall commented Jan 10, 2020

* ugh, sorry about the formatting changes, the precommit hook did that. Let me know if you want me to remove them.

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #715 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #715   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     17           
  Lines         251    251           
  Branches       58     58           
=====================================
  Hits          251    251
Impacted Files Coverage 螖
src/ReactFinalForm.js 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3237bc8...9a0308b. Read the comment docs.

@erikras erikras merged commit ce42986 into final-form:master Jan 21, 2020
@erikras
Copy link
Member

erikras commented Jan 22, 2020

Published in v6.3.4.

@lock
Copy link

lock bot commented Feb 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Typescript + React native
2 participants