Add otherProp to FieldRenderProps interface #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that the FieldRenderProps interface is typed incorrectly, it should actually allow `[otherProp: string]: any;`. Trying to access props other than `input` or `meta` will currently result in a Typescript error. As shown in the docs (here)[https://final-form.org/docs/react-final-form/types/FieldProps#children] arbitrary props assigned to the `Field` component are passed through to the renderProp. ```js <Field name="myField" someArbitraryOtherProp={42}> {props => { console.log(props.someArbitraryOtherProp) // would print 42 return <input {...props.input}/> }} </Form> ``` We can see the passing of props in the `renderComponent` module here: https://github.com/final-form/react-final-form/blob/master/src/renderComponent.js#L25
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 17 17
Lines 251 251
Branches 58 58
=====================================
Hits 251 251Continue to review full report at Codecov.
|
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the FieldRenderProps interface is typed incorrectly, it should actually allow
[otherProp: string]: any;. Trying to access props other thaninputormetawill currently result in a Typescript error.As shown in the docs here arbitrary props assigned to the
Fieldcomponent are passed through to the renderProp.We can see the passing of props in the
renderComponentmodule here: https://github.com/final-form/react-final-form/blob/master/src/renderComponent.js#L25Related issue
Seems an issue is already raised regarding this:
#398