Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-save-selective-debounce to handle clearing inputs #802

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Update auto-save-selective-debounce to handle clearing inputs #802

merged 1 commit into from
Jun 20, 2020

Conversation

jdeniau
Copy link
Contributor

@jdeniau jdeniau commented May 27, 2020

The actual example of auto-save-selective-debounce does not work when the input is cleared.

It does only send the "save" event when the input is changed but not empty.
This is due to the fact that final-form does not send empty values in the values object.

The actual example of `auto-save-selective-debounce` does not work when the input is cleared.

It does only send the "save" event when the input is changed but not empty.
This is due to the fact that final-form does not send empty values in the `values` object.
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e6dd75:

Sandbox Source
competent-bird-yzr98 Configuration
youthful-yalow-4n4dm Configuration
pensive-taussig-mo5ih Configuration
epic-wright-69kb6 Configuration
confident-pare-i35jc Configuration

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #802 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #802   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          253       253           
  Branches        59        59           
=========================================
  Hits           253       253           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d2040...4e6dd75. Read the comment docs.

@erikras erikras merged commit d8ee3a7 into final-form:master Jun 20, 2020
@jdeniau jdeniau deleted the patch-1 branch June 20, 2020 16:19
@erikras
Copy link
Member

erikras commented Jul 13, 2020

Published in v6.5.1.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants