Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] apply generic types to params in useFormState declaration #841

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

alex-fournier
Copy link
Contributor

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 858ab9a:

Sandbox Source
final-form/react-final-form: simple Configuration
final-form/react-final-form: record-level-validation Configuration
final-form/react-final-form: field-level-validation Configuration
final-form/react-final-form: submission-errors Configuration
final-form/react-final-form: subscriptions Configuration

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #841 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #841   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          253       253           
  Branches        59        59           
=========================================
  Hits           253       253           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 353f46f...858ab9a. Read the comment docs.

@BrandonWilliamsCS
Copy link

Just ran into this same issue, and was planning to submit the exact same fix in a new PR. Glad I looked first!
But should we tag @erikras to get some eyes on this?

@erikras erikras merged commit 31d8cb8 into final-form:master Oct 21, 2020
@erikras
Copy link
Member

erikras commented Oct 21, 2020

Published in v6.5.2.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants