Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormProps interface doesn't support custom props. #864

Closed
matiosfree opened this issue Oct 16, 2020 · 1 comment
Closed

FormProps interface doesn't support custom props. #864

matiosfree opened this issue Oct 16, 2020 · 1 comment

Comments

@matiosfree
Copy link
Contributor

matiosfree commented Oct 16, 2020 •
edited

What is the current behavior?

With TypeScript there is an error, when I app extra props.

<Form component={FormComponent} onSubmit={handleSubmit} onCancel={handleCancel} />

Property 'onCancel' does not exist on type 'IntrinsicAttributes & FormProps<any, Partial<{ firstName: string; }>>'.

What is the expected behavior?

There should not be any error.

What's your environment?

"@types/react": "^16.9.49",
"react-final-form": "^6.5.1",

Other information

For the FieldRenderProps we have:
[otherProp: string]: any;

Seems like we need the same for FormProps
matiosfree added a commit to matiosfree/react-final-form that referenced this issue Oct 21, 2020
@matiosfree
Update index.d.ts
ac0198c 
final-form#864 FormProps interface doesn't support custom props.
@matiosfree matiosfree mentioned this issue Oct 21, 2020
Merged
erikras pushed a commit that referenced this issue Oct 21, 2020
@matiosfree
Update index.d.ts (#867)
b487199 
#864 FormProps interface doesn't support custom props.
@erikras
Copy link
Member

erikras commented Oct 21, 2020

Published fix in v6.5.2.

@erikras erikras closed this as completed Oct 21, 2020
@typeofweb typeofweb mentioned this issue Nov 6, 2020
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matiosfree @erikras