fix: stabilize useField public handler identity #931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useField
public handlers likeonFocus
,onChange
,onBlur
are changing their identities based on various internal variables and externally available props/(config parts) likevalue
,name
,parse
etc...I am suggesting that public handlers should not be subject to identity change at all, so that consumers can rely on those without jumping through hoops with
useRef
as in https://reactjs.org/docs/hooks-faq.html#what-can-i-do-if-my-effect-dependencies-change-too-often.As a consequence after this change consumer code relying on this behavior might break, hence this is a BREAKING CHANGE
Closes #816