Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engines in patch release 6.5.4 is a breaking compatibility change #945

Closed
zburke opened this issue Sep 29, 2021 · 3 comments
Closed

engines in patch release 6.5.4 is a breaking compatibility change #945

zburke opened this issue Sep 29, 2021 · 3 comments

Comments

@zburke
Copy link

zburke commented Sep 29, 2021

Are you submitting a bug report or a feature request?

Bug report

What is the current behavior?

Patch release 6.5.4 of react-final-form contains breaking compatibility changes introduced in #943:

// package.json
// …
  "engines": {
    "node": "14"
  },

For users on node < 14 (node v12 is still in maintenance mode through mid-2022) or > 14 (node v16 is in active development), this is a breaking change.

What is the expected behavior?

Patch release should not contain breaking compatibility changes.

Sandbox Link

Not relevant.

What's your environment?

Node v12.22.2

Other information

Relates to final-form/final-form#434

@erikras
Copy link
Member

erikras commented Sep 29, 2021

Should be fixed in v6.5.5.

@erikras erikras closed this as completed Sep 29, 2021
@zburke
Copy link
Author

zburke commented Sep 29, 2021

@erikras, sorry, that didn't do it. I still see engines in the react-final-form package.json in v6.5.5. Bumping final-form from 4.20.3 to 4.20.4 was necessary but not sufficient.

error react-final-form@6.5.5: The engine "node" is incompatible with this module. Expected version "14". Got "16.10.0"
error Found incompatible module.

@erikras
Copy link
Member

erikras commented Sep 29, 2021

Oops. Should really be fixed in v6.5.6. 🤞

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants