Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow git-proxy to be configured both by environment as well as config file(s) #382

Open
4 tasks
coopernetes opened this issue Jan 3, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers protocol Everything related with the developer (git) experience

Comments

@coopernetes
Copy link
Contributor

coopernetes commented Jan 3, 2024

Tracking overall enhancements to how the git-proxy application receives its user configurable values.

Tasks


LGTM - as a future enhancement, we should expose the server ports as both file-based config (via proxy.config.json) as well as environment variables. We should have this available for all our configurable values, merge or reconcile between the two sources and allow users to choose whichever method best suits their deployment to configure ports & other values.

Originally posted by @coopernetes in #379 (review)

@coopernetes coopernetes added the enhancement New feature or request label Jan 3, 2024
@JamieSlome
Copy link
Member

This makes sense. I'd prefer personally customizing via the proxy.config.json but to have the functionality for both is very sensical 👍

Can we just get some minimal requirements or a small tasklist for this issue? Sorting out #384 at the moment, then will get #213 merged, so we can start enforcing code coverage on new functionality, so please also include test cases as a requirement.

As always, thank you @coopernetes ❤️

@coopernetes
Copy link
Contributor Author

Done. I think using a full-fledged configuration library like node-config would cut down on a lot of boilerplate and we can likely remove the requirements for increasing test coverage if a library can handle the merging between sources (similar to how Spring Boot external config works).

@JamieSlome
Copy link
Member

@coopernetes - agreed. If we can get the functionality with test coverage elsewhere that's great.

Also want us to be mindful of dependency bloat. Once we've had some proper architecture conversations post reconcile, we'll address our current dependency bloat in any case.

@JamieSlome JamieSlome added the protocol Everything related with the developer (git) experience label Jan 12, 2024
@JamieSlome JamieSlome added the good first issue Good for newcomers label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers protocol Everything related with the developer (git) experience
Projects
None yet
Development

No branches or pull requests

2 participants