Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace console.log with structured logging #399

Open
coopernetes opened this issue Jan 14, 2024 · 11 comments · May be fixed by #508
Open

Replace console.log with structured logging #399

coopernetes opened this issue Jan 14, 2024 · 11 comments · May be fixed by #508
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers protocol Everything related with the developer (git) experience

Comments

@coopernetes
Copy link
Contributor

Git-proxy does a lot "under the hood". For operators, it would be beneficial for git-proxy to emit messages using structured logging using a library such as winston to better indicate the state of requests flowing through the system.

@coopernetes coopernetes added enhancement New feature or request good first issue Good for newcomers labels Jan 14, 2024
@JamieSlome JamieSlome added the protocol Everything related with the developer (git) experience label Jan 15, 2024
@JamieSlome
Copy link
Member

@coopernetes - good idea. We already have the basis of log functionality on Actions and Steps. We can likely 1-for-1 swap this out with a standard library like winston.

Good idea! 👍

@LewisBroadhurst
Copy link

Taking a look at this over the next few days 😊

@maoo
Copy link
Member

maoo commented Mar 4, 2024

@LMBroadhurst - if you're interested, next Monday (and every 2 weeks) we have 1 hour meeting with all Git Proxy maintainers; if you'd like to show up and get to know each other, please email help@finos.org and I'll take it from there.

Thanks for your help!

@JamieSlome
Copy link
Member

@LMBroadhurst - awesome! 👍 I've assigned the ticket to you.

@LewisBroadhurst
Copy link

Thanks @maoo would love to join. will send an email through.

@abinash2512
Copy link

Hey, @LMBroadhurst I was wondering if you would like some assistance with this issue?

@JamieSlome
Copy link
Member

@LMBroadhurst - I can see you've made progress on your fork and branch. Awesome 🙌

What is outstanding?

@LewisBroadhurst
Copy link

@abinash2512 @JamieSlome Hey guys, sorry caught a nasty bug and was wiped out the last two weeks.

I'm pretty sure the code is in place and ready to go, I just wanted to test it out by using git-proxy and was struggling a bit with it. Going to give it another go this evening to make sure the logging is working as expected.

Also was wondering, would it be useful to actually keep the console.log code, in addition to new logging?

@JamieSlome
Copy link
Member

@LMBroadhurst - hope you are feeling better now - sorry to hear 😢

Let us know if you need any support in testing it; I'm generally always available ❤️

You can ping me here or on the Slack channel!

@LewisBroadhurst
Copy link

@JamieSlome Much better now thanks 😄.

I tried to join the slack channel from the links on the repo but seems you need certain permissions to access the channels. Could you please email me an invite/add me to the slack via my email lewis1broadhurst@gmail.com?

@maoo
Copy link
Member

maoo commented Mar 29, 2024

@JamieSlome Much better now thanks 😄.

I tried to join the slack channel from the links on the repo but seems you need certain permissions to access the channels. Could you please email me an invite/add me to the slack via my email lewis1broadhurst@gmail.com?

Just invited you to Slack! Ping me when you're in, so I can add you to the Git Proxy channel.

Feel free to ping help@finos.org if you encounter any issues. Thanks!

@JamieSlome JamieSlome linked a pull request Apr 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers protocol Everything related with the developer (git) experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants