Git Proxy does not support GitLab repos

[msagi]

Describe the bug
Failed to do git push with a GitLab repo.

To Reproduce
Steps to reproduce the behavior:

1. unzip gitlab-issue.tar.gz
2. start git-proxy with the config file (proxy.config.json) from the .tar.gz file
3. execute git-proxy-issue-repro.sh
4. compare the *.run.log files with your run logs
5. compare .data/db files with your data

Expected behavior
git push is successful (with GitLab repo)

Screenshots
n/a

Desktop (please complete the following information):

• OS: macOS 14.4.1 (23E224)
• Git: git version 2.39.3 (Apple Git-146)
• Browser n/a
• Version n/a

Additional context
src/proxy/actions/Action.js: 56
this.url = https://github.com/${repo};

this might be the cause of the issue: GitHub is hardcoded baseURL into the action

[abinash2512]

Happy to pick this one up while waiting for #414 to be approved license-wise

[JamieSlome]

@abinash2512 - awesome, fire away! 🔥

[msagi]

@JamieSlome @abinash2512 - I believe, we lose the git server domain name with git remote set-url origin <git-proxy-host:port>/repo-name.git. Unless we match incoming push requests with the list of authorised repos in proxy.config.json , we won't be able to tell the domain name. This way, GitProxy becomes able to support multiple Git servers but the project/repo-name must stay unique across the ecosystem, aka GitProxy won't be able to support https://gitlab.com/msagi/test-repo.git and https://github.com/msagi/test-repo.git at the same time.

[msagi]

Hi @abinash2512 , how are you doing with this issue? Do you need help? I’m happy to chip in 🚀🚀🚀

[msagi]

Hi @abinash2512 @JamieSlome , I've spent some time with this issue. Perhaps this is a bit more complex than a good-first-issue. Can you take a look at the PR I made, and give me any feedback or comments?

[JamieSlome]

Removing good first issue as it appears a little more extensive than initially thought 👍