Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Remove support for multiple SDLC instances #935

Closed
8 tasks done
akphi opened this issue Mar 12, 2022 · 0 comments · Fixed by #1041
Closed
8 tasks done

Feature request: Remove support for multiple SDLC instances #935

akphi opened this issue Mar 12, 2022 · 0 comments · Fixed by #1041
Assignees
Labels
Application: Studio Issues related to Legend Studio application Component: SDLC Type: Feature Request
Milestone

Comments

@akphi
Copy link
Contributor

akphi commented Mar 12, 2022

Similar requests

  • I have searched and found no existing similar requests

How are you using Studio?

Legend Studio

What problems are you trying to solve?

We decided that the overall use case for multiple SDLC instances have a few drawbacks:

  1. It's generally confusing in the UI to indicate this, especially it obfuscates the URL. Generally, we are quite conservative about URL patterns in our app
  2. The code logic to support this is unnecessarily complicated.
  3. BONUS If we remove URL patterns setup used to support this feature, Feature request: Upgrade react-router@6 #688 would be much easier.

Hence, we decided to remove the support for it. We basically undo the work of #642 and #149

Describe the solution you would like to see implemented

Tasks

  • Remove the code logic
  • Write docs about this (potentially)

For migration/backward compatibility

  • Either modularize the NotFound page behavior so for existing infrastructure or we could rely on the doc config provided to make decision whether or not the show the NotFound page
  • For existing infrastructure that deploys Studio with multiple SDLC instances, add new deployment of /studio at routes like /gcp-cloud-sdlc-studio/, /onprem-sdlc-studio/, aws-sdlc-studio/, etc. We can also make use of the existing studio.config.js file with tweak to change baseUrl based on an environment variable to create specific deployment artifacts
  • Refactor the path for viewer mode with GAV to view/archive/...

Extra

Describe alternatives you have considered

No response

Documentation, Design, Adoption, Migration Strategy

No response

Contribution

  • I would like to work on this feature
@akphi akphi self-assigned this Mar 12, 2022
@akphi akphi added this to the 5.0.0 milestone Mar 12, 2022
@github-actions github-actions bot added the Studio Core Team Opened by a member of the Studio core team label Mar 12, 2022
@akphi akphi added Component: SDLC Application: Studio Issues related to Legend Studio application and removed Studio Core Team Opened by a member of the Studio core team labels Mar 12, 2022
@akphi akphi changed the title Feature request: Remove support fort multiple SDLC instances Feature request: Remove support for multiple SDLC instances Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Application: Studio Issues related to Legend Studio application Component: SDLC Type: Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant