Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support schema mapping when entity type is different from table type #1296

Open
naleeha opened this issue Apr 17, 2024 · 0 comments
Open

Support schema mapping when entity type is different from table type #1296

naleeha opened this issue Apr 17, 2024 · 0 comments
Assignees
@junaidzm13
Labels
server UI user Interface

Comments

@naleeha
Copy link
Contributor

naleeha commented Apr 17, 2024

Feature Request

Description of Problem:

Example when we need this

  • Big decimal, until it is supported Support BigDecimal #1295
  • Table Key expects to be String but entity in data source key are not always string

Considerations

  • Use cases in Java

Potential Solutions:
@naleeha naleeha added UI user Interface server labels Apr 17, 2024
@junaidzm13 junaidzm13 self-assigned this Apr 22, 2024
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 22, 2024
@junaidzm13
finos#1296 add TypeConverter class with simple tests and some default…
cac2d88 
… converters
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 22, 2024
@junaidzm13
finos#1296 support for conversion from primitive to wrapper types for…
66fc82e 
… consistency
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 23, 2024
@junaidzm13
finos#1296 add TypeConverterContainer and related tests
912aafe 
Also some improvements and refactoring on previous changes
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 24, 2024
@junaidzm13
finos#1296 improvements and refactoring on previous changes / TypeCon…
d2531bb 
…verterContainer enhancements / TypeUtils introduced
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 24, 2024
@junaidzm13
finos#1296 add one-way type conversions to SchemaMapper
e1858bd
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 24, 2024
@junaidzm13
finos#1296 add 3 more default type converters + tests for DefaultType…
af4772c 
…Converters
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 24, 2024
@junaidzm13
finos#1296 SchemaMapper improvements
d6660ca
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 24, 2024
@junaidzm13
finos#1296 in-progress
33a9c21
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 add type conversions required for sql filters
f4296fd
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 casting/method signature improvements in SchemaMapper
e4591c7
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 adding SchemaMapper tests
757feec
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 TypeConverterContainer cleanups
88e59df
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 introduce SchemaMapperBuilder
df0d0e6
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 add remaining DefaultTypeConverters
e89ee2b
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 add tests for DataType.parseToDataType
6e8ebf2
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 add todos, stuff that needs to be changed before final PR
05e4b90
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 25, 2024
@junaidzm13
finos#1296 add guard against .asInstanceOf inside TypeConverterContai…
3ea8671 
…ner.convert
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 SchemaMapperTest + SchemaMapper improvements
663fb46
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 SQL filtering tests
eb38607
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 add todos, stuff that needs to be changed before final PR
6b154e8
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 SchemaMapperTest + SchemaMapper improvements
afadde4
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 SQL filtering tests
d43d0f9
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 TypeConverterContainer improvements + tests
4709a10
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 Complete IgniteSqlFilterClause changes + add tests
f29e4be
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 remove convertExternalValueToString from SchemaMapper
a43f16b 
- with this change we've also started using built-in `toString`
  methods to convert external values to strings for SQL filter
  queries. If required can always allow users to opt-out of this by
  providing `SomeType->String` type converters and passing that
  to `SqlFilterColumnValueParser`.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 move util.schema.typeConversion folder to util.types
e462ed3
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 26, 2024
@junaidzm13
finos#1296 improve/cleanup ExternalEntitySchema
5180170
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 29, 2024
@junaidzm13
finos#1296 fix failing tests in IgniteSqlFilteringTest
b8ef0b5
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 29, 2024
@junaidzm13
finos#1296 improve SqlFilterColumnValueParser to use opt-in SqlString…
17afd34 
…ConverterContainer so users can specify custom external-value -> sql-string conversions
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 29, 2024
@junaidzm13
finos#1296 add tests in IgniteSqlFilteringTest for missing Boolean da…
4452dd4 
…ta type
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 29, 2024
@junaidzm13
finos#1296 Make FilterColumnValueParser independent of SQL use-case
488c3d1 
- it is now just a utility to convert column value (String) from ANTLR
  to external value (original external date type) that will then be used
  with external data source for filtering.
- In the process makes it responsible only for one thing i.e. parse column
  value (String) to external value's data type. Should not care about how
  we convert the resulting external value to a String understood by SQL.
  That logic's been moved back to IgniteSqlFilterClause.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 29, 2024
@junaidzm13
finos#1296 add comment for DataType.parseToDataType
fa6a067
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 add type conversions capability to SchemaMapper
382b1cf
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 introduce SchemaMapperBuilder for easier instantiation
7a8674e 
- this commit also adds more DefaultTypeConverters and some missing tests
  for DataType.parseToDataType.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 add todos, stuff that needs to be changed before final PR
e9846fe
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 add type conversion related SQL filter tests
d0479eb
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 add small improvements to TypeConverterContainer class
1a97dc5
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 complete IgniteSqlFilterClause changes and add tests
e218b5b 
- also removes `convertExternalValueToString` from `SchemaMapper`
  and moves it to Filtering use-case as it has nothing to do with
  schema mapping logic.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 move util.schema.typeConversion folder to util.types
eac070e
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 improve and add pending cleanups to ExternalEntitySchema
eae83a2
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 fix failing tests in IgniteSqlFilteringTest
fb86040
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 improve SqlFilterColumnValueParser to use opt-in SqlString…
cf88a40 
…ConverterContainer

- this allows users to specify custom external-value -> sql-string converters.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 add tests in IgniteSqlFilteringTest for missing Boolean da…
3dd67cf 
…ta type
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 make FilterColumnValueParser independent of SQL use-case
3d6e70a 
- it is now just a utility to convert column value (String) from ANTLR
  to external value (original external date type) that will then be used
  with external data source for filtering.
- In the process makes it responsible only for one thing i.e. parse column
  value (String) to external value's data type. Should not care about how
  we convert the resulting external value to a String understood by SQL.
  That logic's been moved back to IgniteSqlFilterClause.
- also renames SqlStringConverterContainer to less verbose ToSqlStringContainer.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 make parseToDataType to return Option for easier usage w…
2e773e1 
…ith java
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue Apr 30, 2024
@junaidzm13
finos#1296 remove ToSqlStringContainer.scala
d44c579
heswell pushed a commit that referenced this issue Apr 30, 2024
@junaidzm13
1296 schema mapper type conversions (#1311)
d618f9c 
* #1296 add TypeConverter class with simple tests and some default converters

#1296 support for conversion from primitive to wrapper types for consistency

#1296 add TypeConverterContainer and related tests

Also some improvements and refactoring on previous changes

#1296 improvements and refactoring on previous changes / TypeConverterContainer enhancements / TypeUtils introduced

#1296 add 3 more default type converters + tests for DefaultTypeConverters

* #1296 add type conversions capability to SchemaMapper

* #1296 introduce SchemaMapperBuilder for easier instantiation

- this commit also adds more DefaultTypeConverters and some missing tests
  for DataType.parseToDataType.

* #1296 add todos, stuff that needs to be changed before final PR

* #1296 add type conversion related SQL filter tests

* #1296 add small improvements to TypeConverterContainer class

* #1296 complete IgniteSqlFilterClause changes and add tests

- also removes `convertExternalValueToString` from `SchemaMapper`
  and moves it to Filtering use-case as it has nothing to do with
  schema mapping logic.

* #1296 move util.schema.typeConversion folder to util.types

* #1296 improve and add pending cleanups to ExternalEntitySchema

* #1296 fix failing tests in IgniteSqlFilteringTest

* #1296 improve SqlFilterColumnValueParser to use opt-in SqlStringConverterContainer

- this allows users to specify custom external-value -> sql-string converters.

* #1296 add tests in IgniteSqlFilteringTest for missing Boolean data type

* #1296 make FilterColumnValueParser independent of SQL use-case

- it is now just a utility to convert column value (String) from ANTLR
  to external value (original external date type) that will then be used
  with external data source for filtering.
- In the process makes it responsible only for one thing i.e. parse column
  value (String) to external value's data type. Should not care about how
  we convert the resulting external value to a String understood by SQL.
  That logic's been moved back to IgniteSqlFilterClause.
- also renames SqlStringConverterContainer to less verbose ToSqlStringContainer.

* #1296 make `parseToDataType` to return Option for easier usage with java

* #1296 remove ToSqlStringContainer.scala
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 1, 2024
@junaidzm13
finos#1296 use parameterized SQL query builder
4ee7c7a 
- this would prevent SQL injection while adding better support
  for different types i.e. for instance before we had to manually
  convert values to strings (with or without quotes depending on
  the type) before using those in SQL query. Now, ignite ignite
  would do that for us out of the box.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 1, 2024
@junaidzm13
finos#1296 use parameterized SQL query builder
3f656ae 
- this would prevent SQL injection while adding better support
  for different types i.e. for instance before we had to manually
  convert values to strings (with or without quotes depending on
  the type) before using them in SQL query. Now, ignite would do
  that for us.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 1, 2024
@junaidzm13
finos#1296 add follow-up tests / naming improvements
0a114ad 
- remove java tests suite that was added only to gauge Java
  friendliness of the API.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 1, 2024
@junaidzm13
finos#1296 add follow-up tests / naming improvements
03a8b96 
- also removes java test suite that was added only to gauge Java
  friendliness of the API.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 1, 2024
@junaidzm13
finos#1296 use parameterized SQL query builder
978bd83 
- this would prevent SQL injection while adding better support
  for different types i.e. for instance before we had to manually
  convert values to strings (with or without quotes depending on
  the type) before using them in SQL query. Now, ignite would do
  that for us.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 1, 2024
@junaidzm13
finos#1296 use parameterized SQL query builder
cf98d15 
- this would prevent SQL injection while adding better support
  for different types i.e. for instance before we had to manually
  convert values to strings (with or without quotes depending on
  the type) before using them in SQL query. Now, ignite would do
  that for us.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 1, 2024
@junaidzm13
finos#1296 add follow-up tests / naming improvements
fac875d 
- also removes java test suite that was added only to gauge Java
  friendliness of the API.
junaidzm13 added a commit to junaidzm13/vuu that referenced this issue May 1, 2024
@junaidzm13
finos#1296 add follow-up tests / naming improvements
9e3d4b6 
- also removes java test suite that was added only to gauge Java
  friendliness of the API.
heswell pushed a commit that referenced this issue May 1, 2024
@junaidzm13
#1296 use parameterized SQL query builder (#1319)
09d7122 
- this would prevent SQL injection while adding better support
  for different types i.e. for instance before we had to manually
  convert values to strings (with or without quotes depending on
  the type) before using them in SQL query. Now, ignite would do
  that for us.
heswell pushed a commit that referenced this issue May 1, 2024
@junaidzm13
#1296 add follow-up tests / naming improvements (#1321)
25f4f4d 
- also removes java test suite that was added only to gauge Java
  friendliness of the API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junaidzm13 junaidzm13

Labels
server UI user Interface
Projects
Vuu board
Status: 👀 To be tested in QA
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junaidzm13 @naleeha