Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when table metadata is sent to client, preserve order of table columns as created in module #1308

Open
heswell opened this issue Apr 23, 2024 · 1 comment
Open

when table metadata is sent to client, preserve order of table columns as created in module #1308

heswell opened this issue Apr 23, 2024 · 1 comment
Assignees
@junaidzm13
Labels
server

Comments

@heswell
Copy link
Contributor

heswell commented Apr 23, 2024

vuu server sends list of column names, along with column types, in TABLE_META response. Column names are ordered alphabetically.
Can we preserve the order of column names in this list to match the order in which columns were defined on the table definition.

That way. columns can be defined in the order that makes most sense for display to UI, without additional configuration on the client.
@heswell heswell added the server label Apr 23, 2024
@naleeha
Copy link
Contributor

naleeha commented Apr 29, 2024

GetTableMetaResponse currently sorts the columns
Need to return the columns in the order it was defined in the TableDef to enable driving of the table column order from server side. This remove the need for UI configuration to set the column order in default cases.

@naleeha naleeha mentioned this issue Apr 29, 2024
Closed
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue May 13, 2024
@junaidzm13
finos#1308 sort column names by their indexes in sent table meta
05e82b4
@naleeha naleeha mentioned this issue May 13, 2024
Merged
heswell pushed a commit that referenced this issue May 13, 2024
@naleeha @junaidzm13
Row has changed check, contains filter, column names sorting (#1333)
3c2bc32 
* #907 add hasRowChanged.* methods on In-Mem/Virtual tables

* #884 add `contains` operator to filters

- also adds unit-tests in IgniteSqlFilterClauseTest.
- also adds `escapeSpecialChars` method to escape special characters with `LIKE`
  operator.
- adds small follow-up improvements to IgniteSqlQuery, introduces a
  factory method apply(sqlTemplate: String, args: Any*) for cleaner
  and flexible usage.

* #1308 sort column names by their indexes in sent table meta

* #884 add suggested improvements from review

---------

Co-authored-by: Malik, Junaid <junaid.malik@ubs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junaidzm13 junaidzm13

Labels
server
Projects
Vuu board
Status: 👀 To be tested in QA
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heswell @junaidzm13 @naleeha