Update multi-tenancy integration tests to run against auth emulator #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisajian
force-pushed
the
lj-deleteBody
branch
2 times, most recently
from
248b00e
to
73415dc
Compare
yuchenshi
requested changes
Oct 13, 2021
lisajian
force-pushed
the
lj-deleteBody
branch
from
5f67e2d
to
d904f3c
Compare
lisajian
force-pushed
the
lj-deleteBody
branch
from
d904f3c
to
f57c7d7
Compare
yuchenshi
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Update multi-tenancy integration tests to pass against auth emulator. Notable changes includes:
DO NOT LAND UNTIL: firebase/firebase-tools#3818 and firebase/firebase-tools#3822 is merged to mainline
Corresponding internal bug: b/192387245
Testing
npm run buildin auth emulator, followed bynode /Users/lisajian/dev/firebase-tools/lib/bin/firebase emulators:exec --project fake-project-id --only auth,database,firestore 'npx mocha \"test/integration/auth.spec.ts\" --slow 5000 --timeout 20000 --require ts-node/register --testMultiTenancy'passes in firebase-admin-node SDKAPI Changes
N/A