Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): Remove request body for deleteTenant #1461

Merged
merged 2 commits into from
Oct 14, 2021
Merged

fix(auth): Remove request body for deleteTenant #1461

merged 2 commits into from
Oct 14, 2021

Conversation

lisajian
Copy link
Contributor

Discussion

This change reverts #1456, which reverted the original PR #1452.

Corresponding internal bug: b/192387245

Testing

npm test passes

API Changes

N/A

@lisajian lisajian marked this pull request as ready for review October 13, 2021 20:49
yuchenshi
yuchenshi approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge when code freeze is over

@hiranya911 hiranya911 changed the title Remove request body for deleteTenant fix(auth): Remove request body for deleteTenant Oct 14, 2021
hiranya911
hiranya911 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

Code freeze is over. Feel free to merge when ready.

@lisajian lisajian merged commit 4bef8fa into firebase:master Oct 14, 2021
@lisajian lisajian deleted the lj-deleteBody-rollForward branch October 14, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@yuchenshi yuchenshi

Labels
release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lisajian @hiranya911 @yuchenshi @lahirumaramba