Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Add user disabled error code. #1506

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

xil222
Copy link
Contributor

@xil222 xil222 commented Nov 22, 2021

Add disabled error code, to avoid unparsed internal error in createSessionCookie(). see issue

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Xin! LGTM!

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Nov 23, 2021
@lahirumaramba
Copy link
Member

@xil222 I added the staging label to trigger integration tests. If you can please push an empty commit and that will trigger our CIs before we merge this change. Thanks!

git commit --allow-empty -m "Trigger integration tests"

@xil222 xil222 merged commit 7ce2345 into master Nov 23, 2021
@lahirumaramba lahirumaramba deleted the fixCreateSessionCookieError branch December 14, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createSessionCookie does not pick up USER_DISABLED errors
2 participants