chore: Update ESLint and @typescript-eslint dependencies #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
force-pushed
the
lm-update-eslint
branch
from
69dcab9
to
86f643e
Compare
hsubox76
reviewed
Jan 13, 2022
hsubox76
approved these changes
Jan 13, 2022
lahirumaramba
added a commit
that referenced
this pull request
Jan 14, 2022
This is the second PR of a series of changes to update @google-cloud/firestore dependency to 5.x. This is a follow-up to #1540 - Upgraded Typescript from ~3.7.3 to ~4.4.3 - Fixed TS2790: The operand of a 'delete' operator must be optional errors Note: Manually tested for backwards compatibility on TS 3.7.x to 4.5.x. We will add TS compatibility tests to CIs in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of a series of changes to update
@google-cloud/firestoredependency to 5.x.@google-cloud/firestore5.x requires typescript 4.x, which breaks the currenttypescript-eslintversions we use. An immediate workaround is to replace tuple types with arrays. The proper fix is to updateeslintandtypescript-eslintdependencies.We have decided to fix this properly by updating the dependencies. We are addressing this in multiple PRs and as the first step this change handles the
eslintupdate.eslintto^7.1.0,@typescript-eslint/eslint-pluginand@typescript-eslint/parserto^5.0.0.camelcasecheck has been replaced with@typescript-eslint/naming-convention. Updated the config to reflect this change and removed the previously useddisable camelcaserules.@typescript-eslint/naming-conventionworks quite differently from the previous@typescript-eslint/camelcasecheck. I disabled a few checks for now and we will enable them fixing the errors as we go in the future.