Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Support generate oob code request type VERIFY_AND_CHANGE_EMAIL #1633

Merged
merged 6 commits into from Apr 28, 2022

Conversation

Xiaoshouzi-gh
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh commented Apr 6, 2022

Support generate email link for VERIFY_AND_CHANGE_EMAIL action.

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

…generation method.

Added more unit tests.
Updated the method name.
@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review April 19, 2022 22:43
Copy link

@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* mobile app or browser along with additional state information to be passed in
* the deep link, etc.
*
* @param email - The current email account.
Copy link

@renkelvin renkelvin Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"email address"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept it as email account as the previous public method (verify_email, reset_password etc) uses the same documentation on email paramater. Let me know if you feel strong about email address.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few comments. Thanks!

test/unit/auth/auth-api-request.spec.ts Outdated Show resolved Hide resolved
src/auth/auth-api-request.ts Outdated Show resolved Hide resolved
@lahirumaramba lahirumaramba changed the title Support generate oob code request type VERIFY_AND_CHANGE_EMAIL feat (auth): Support generate oob code request type VERIFY_AND_CHANGE_EMAIL Apr 27, 2022
@lahirumaramba lahirumaramba changed the title feat (auth): Support generate oob code request type VERIFY_AND_CHANGE_EMAIL feat(auth): Support generate oob code request type VERIFY_AND_CHANGE_EMAIL Apr 27, 2022
@lahirumaramba
Copy link
Member

Please get TW's approval on the reference docs before you merge this. Thank you!

src/auth/base-auth.ts Outdated Show resolved Hide resolved
src/auth/base-auth.ts Outdated Show resolved Hide resolved
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit b2a28ae into master Apr 28, 2022
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the verify-change-email branch April 28, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants