feat(auth): reCAPTCHA Public preview #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragatimodi
approved these changes
Mar 31, 2023
lahirumaramba
changed the title
lahirumaramba
approved these changes
Apr 4, 2023
prameshj
approved these changes
Apr 6, 2023
src/auth/auth-config.ts
Outdated
| /** | ||
| * The key's platform type: only web is currently supported. | ||
| */ | ||
| export type RecaptchaKeyClientType = 'WEB'; |
There was a problem hiding this comment.
We actually support ANDROID and IOS too..
Does this mean the config returned will not show the mobile platform keys?
There was a problem hiding this comment.
Nice catch! We do return all 3 keys since we don't validate the key response. I think only web was supported at the time. Updated with all 3 type in the new commit.
Xiaoshouzi-gh
force-pushed
the
public-preview
branch
from
2e127f3
to
938f9a0
Compare
* Defined reCAPTCHA config. - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config.
* Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations.
* Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents.
* Added integ test for Project Config and Tenants update on reCAPTCHA config
* Support use_account_defender add-on feature for reCAPTCHA config. * Added integration test for account defender feature
- Fix merge conflicts with sms region change - Do not throw exceptions enabling account defender when recaptcha is OFF
Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com>
Xiaoshouzi-gh
force-pushed
the
public-preview
branch
from
938f9a0
to
ca3c818
Compare
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 17, 2023
This reverts commit 0bf7d29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased branch against master with recaptcha features.
The changes has all been previously reviewed and approved.
This is the branch we will merge once we are ready for release.
RELEASE NOTE: Added reCAPTCHA configuration support.