Make WrappedFunction curry type info #138
Merged
+543
−442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheIronDev
reviewed
May 5, 2022
| function generateBaseCloudEvent<EventType extends CloudEvent<unknown>>( | ||
| cloudFunction: CloudFunction<EventType> | ||
| ): EventType { | ||
| // TODO: Consider refactoring so that we don't use this utility function. This |
TheIronDev
reviewed
May 5, 2022
| import { alertsBillingOnPlanUpdatePublished } from './alerts/billing-on-plan-update-published'; | ||
| import { eventarcOnCustomEventPublished } from './eventarc/eventarc-on-custom-event-published'; | ||
| import { pubsubOnMessagePublished } from './pubsub/pubsub-on-message-published'; | ||
| import { storageV1 } from './storage'; |
There was a problem hiding this comment.
Shouldn't there be a new file here?
There was a problem hiding this comment.
src/cloudevent/partials/partials.ts:14:27 - error TS2307: Cannot find module './storage' or its corresponding type declarations.
14 import { storageV1 } from './storage';
There was a problem hiding this comment.
Indeed. Added missing file back.
TheIronDev
reviewed
May 5, 2022
| cloudFunction: CloudFunctionV2<T> | ||
| ): WrappedV2Function<T>; | ||
|
|
||
| export function wrap<T, V extends CloudEvent<unknown>>( |
There was a problem hiding this comment.
I like this function overloading much better than what I did earlier 🐢
TheIronDev
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry that the formatter made a bunch of changes. The majority of the impactful changes here are that the wrapped function types keep the type info of the functions that they wrap. This also required us a fix to the
CloudFunctiontype because it is now generic based on an EventType rather than event data so that we can keep type info for subtypes of CloudEvent.I'd like to eventually look at refactoring this to have fewer places where we have
any. I think we might want to have three pieces:function baseEvent<T>(): Omit<CloudEvent<any>, 'data'>that returns what you have today. Then in each partial you do the combination ofbaseEventwith per-event type overrides (e.g. bucket for Storage) and the partial data. By putting the event construction lower in the stack we can make sure data is referentially correct (e.g. the StorageEvent.bucket matches the StorageEvent.data.bucket)