Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: firebase/firebase-functions
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.17.1
Choose a base ref
...
head repository: firebase/firebase-functions
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.17.2
Choose a head ref
  • 3 commits
  • 8 files changed
  • 2 contributors

Commits on Feb 4, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    4b3b9b8 View commit details

Commits on Feb 7, 2022

  1. Unbreak v2 TS users by safely removing duplicated manifest definition (

    …#1033)
    
    Follows up #1032 for V2 API to fix #1031.
    
    While rebasing the branch that moved the location of manifest definition (#1003), the original file was not removed and cleaned up. Having long-lasting PR is dangeroud 🤦🏼‍♂️ .
    taeold authored Feb 7, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    9da9a4e View commit details
  2. 3.17.2

    google-oss-bot committed Feb 7, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c34553a View commit details
Showing with 7 additions and 93 deletions.
  1. +1 −1 CHANGELOG.md
  2. +2 −2 package-lock.json
  3. +1 −1 package.json
  4. +1 −1 src/cloud-functions.ts
  5. +0 −83 src/common/manifest.ts
  6. +1 −1 src/providers/https.ts
  7. +0 −3 src/runtime/manifest.ts
  8. +1 −1 src/v2/providers/alerts/alerts.ts
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
- Fix issue where TS users couldn't compile their code because of unexported types. (#1032)
- Fix issue where v2 TS users couldn't compile their code because of unexported types. (#1033)
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "firebase-functions",
"version": "3.17.1",
"version": "3.17.2",
"description": "Firebase SDK for Cloud Functions",
"keywords": [
"firebase",
2 changes: 1 addition & 1 deletion src/cloud-functions.ts
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ import {
durationFromSeconds,
serviceAccountFromShorthand,
} from './common/encoding';
import { ManifestEndpoint, ManifestRequiredAPI } from './common/manifest';
import { ManifestEndpoint, ManifestRequiredAPI } from './runtime/manifest';

/** @hidden */
const WILDCARD_REGEX = new RegExp('{[^/{}]*}', 'g');
83 changes: 0 additions & 83 deletions src/common/manifest.ts

This file was deleted.

2 changes: 1 addition & 1 deletion src/providers/https.ts
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ import {
convertInvoker,
copyIfPresent,
} from '../common/encoding';
import { ManifestEndpoint, ManifestRequiredAPI } from '../common/manifest';
import { ManifestEndpoint, ManifestRequiredAPI } from '../runtime/manifest';
import {
CallableContext,
FunctionsErrorCode,
3 changes: 0 additions & 3 deletions src/runtime/manifest.ts
Original file line number Diff line number Diff line change
@@ -20,7 +20,6 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
/**
* @internal
* An definition of a function as appears in the Manifest.
*/
export interface ManifestEndpoint {
@@ -68,14 +67,12 @@ export interface ManifestEndpoint {
};
}

/* @internal */
export interface ManifestRequiredAPI {
api: string;
reason: string;
}

/**
* @internal
* An definition of a function deployment as appears in the Manifest.
**/
export interface ManifestStack {
2 changes: 1 addition & 1 deletion src/v2/providers/alerts/alerts.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ManifestEndpoint } from '../../../common/manifest';
import { ManifestEndpoint } from '../../../runtime/manifest';
import { CloudEvent, CloudFunction } from '../../core';
import * as options from '../../options';