Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-portable path warnings from Protobuf pod #2665

Closed
OscarGorog opened this issue Mar 28, 2019 · 22 comments · Fixed by #3987
Closed

Non-portable path warnings from Protobuf pod #2665

OscarGorog opened this issue Mar 28, 2019 · 22 comments · Fixed by #3987

Comments

@OscarGorog
Copy link

Please update for Swift 5 support.

Thanks!

@google-oss-bot

This comment has been minimized.

@maksymmalyhin
Copy link
Contributor

@OkiRules Thank you for your request. For most of the components Swift 5 should be supported now. Would you be able to provide examples of the issues you have with Swift 5, please?

@OscarGorog
Copy link
Author

Screen Shot 2019-03-29 at 8 23 03 pm

@paulb777
Copy link
Member

This is an Apple issue tracked at https://openradar.appspot.com/radar?id=6091887509241856. More discussion at protocolbuffers/protobuf#3218.

We can investigate if we can find any better workarounds. In the meantime, it's safe to ignore the warnings.

@paulb777
Copy link
Member

I'm going to change the title since the issue is not related to Swift 5.

@paulb777 paulb777 changed the title Please update for Swift 5 support. Non-portable path warnings from Protobuf pod Mar 29, 2019
paulb777 added a commit that referenced this issue Apr 6, 2019
@paulb777
Copy link
Member

paulb777 commented Apr 6, 2019

One workaround is adding pod 'Protobuf', :inhibit_warnings => true to the Podfile.

@paulb777
Copy link
Member

Sent protocolbuffers/protobuf#6190

@Deni0S
Copy link

Deni0S commented Aug 4, 2019

It worked, it was enough to change the letter of the folder: Pods/Protobuf/objectivec/google/protobuf (protobuf -> Protobuf)

@paulb777
Copy link
Member

paulb777 commented Aug 6, 2019

protocolbuffers/protobuf#6464 in progress to fix

@devkokodev
Copy link

I'm trying to install 'Firebase/Messaging' it install protobuf etc. I'm using swift 5, deployment ios 11 and i have this issues:
Screen Shot 2019-08-08 at 10 44 49 AM
Screen Shot 2019-08-08 at 10 45 15 AM
Screen Shot 2019-08-08 at 10 49 55 AM

I've tried (cmd + shift + k) delete derived data, pod install, pod update, nothing solved this issue.
Any help?

@paulb777
Copy link
Member

paulb777 commented Aug 8, 2019

@devkokodev That looks like a different issue. Perhaps, something in the configuration? We'll likely need more information about reproducing to help. Please open another issue with that detail.

@juliocbcotta
Copy link

So, now that the PR in cocoapods is merged... all that is needed is to update the protobuf lib in this repository?
As far as I can tel https://github.com/firebase/firebase-ios-sdk/blob/master/FirebaseMessaging.podspec#L52 is the current version, right? As the version differences are not so small, I image it should be with care. @paulb777 this is something in your radar, right?

@paulb777
Copy link
Member

@BugsBunnyBR A new Protobuf version with that PR needs to be published to CocoaPods. Please enquire in the Protobuf repo about their release plans. Firebase will automatically pick up a subsequent Protobuf minor release on a pod update.

@juliocbcotta
Copy link

I thought is was in this release https://github.com/protocolbuffers/protobuf/releases/tag/v3.9.1, but is looks like it is not here yet. Sorry for the misunderstanding.

@TillemanM
Copy link

It worked, it was enough to change the letter of the folder: Pods/Protobuf/objectivec/google/protobuf (protobuf -> Protobuf)

thank you!!! this fixed it.

@navingp
Copy link

navingp commented Aug 24, 2019

@OkiRules did you resolved this "Non-portable path warnings from Protobuf pod."
your help is much appreciated.

@OscarGorog
Copy link
Author

Not yet as the new build has not been updated for Cocoapods but when it is will inform you.

@navingp
Copy link

navingp commented Aug 25, 2019

@OkiRules Thanks for the quick reply..

@juliocbcotta
Copy link

I think protocolbuffers released a version with the fix
https://github.com/protocolbuffers/protobuf/releases

Can someone take a look at the update process ?

@paulb777
Copy link
Member

@BugsBunnyBR The fix won't come until Protocol buffers releases 3.10.0. 3.9.2 was a single patch to 3.9.0 fix a crash issue (#3851).

@juliocbcotta
Copy link

juliocbcotta commented Sep 24, 2019

Ohh... I looked for the 6464 PR merge tag and it was in a release... but it was for version for 3.10 RC1, I should pay more attention.

@paulb777
Copy link
Member

paulb777 commented Oct 3, 2019

Protobuf 3.10.0 has been published to CocoaPods. Doing some additional Firebase integration testing today.

@firebase firebase locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants