Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: firebase/firebase-js-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: firebase@9.6.7
Choose a base ref
...
head repository: firebase/firebase-js-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: firebase@9.6.8
Choose a head ref
  • 11 commits
  • 85 files changed
  • 7 contributors

Commits on Feb 18, 2022

  1. document_overlay_cache.test.ts: added a test for updating a document'… 

    …s overlay (#6015)

* document_overlay_cache.test.ts: added a test for updating a document's overlay, ported from firebase/firebase-ios-sdk@cf04e67

* document_overlay_cache.test.ts: replace it.only() that was accidentally left in with it()
    @dconeybe
    dconeybe authored Feb 18, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    c8907fa View commit details

Commits on Feb 19, 2022

  1. Merge branch 'release' 

    Release 9.6.7
    @hsubox76
    hsubox76 committed Feb 19, 2022
    Copy the full SHA
    9fb82cb View commit details

Commits on Feb 22, 2022

  1. Implement Index Scanning (#6008)

    @schmidt-sebastian
    schmidt-sebastian authored Feb 22, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    13c0895 View commit details

Commits on Feb 24, 2022

  1. Fix SortedMap's reverse iterator (without start key). (#6020) 

    * Fix SortedMap's reverse iterator (without start key).

* Fix sorted map.

* address comments.
    @ehsannas
    ehsannas authored Feb 24, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    8ac8fb0 View commit details

  2. Add await to onBackgroundMessage callback (#5762)

    @zwu52
    zwu52 authored Feb 24, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    091e867 View commit details

  3. Implement heartbeat controller (#5723)

    @hsubox76
    hsubox76 authored Feb 24, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    1588990 View commit details

  4. Add Changeset for pull/5762 (#6030) 

    * Create pretty-mayflies-worry.md

* Update pretty-mayflies-worry.md
    @zwu52
    zwu52 authored Feb 24, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    b3e4af8 View commit details

  5. Make getNextCollectionGroupToUpdate() deterministic (#6031)

    @schmidt-sebastian
    schmidt-sebastian authored Feb 24, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    2b98b28 View commit details

Commits on Feb 28, 2022

  1. Use interfaces for IndexedDB (#6029)

    @schmidt-sebastian
    schmidt-sebastian authored Feb 28, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    27ed845 View commit details

  2. Use ObjectMap instead of Map with proper comparator. (#6018) 

    * Use ObjectMap instead of Map with proper comparator.

* use documentKeySet.

* Address comments.

* prettier.

* Update names.
    @ehsannas
    ehsannas authored Feb 28, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    09e6243 View commit details

Commits on Mar 4, 2022

  1. Version Packages (#6049) 

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    @google-oss-bot @github-actions
    google-oss-bot and github-actions[bot] authored Mar 4, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    34a9ae9 View commit details
Showing with 3,860 additions and 1,303 deletions.
  1. +4 −4 integration/compat-interop/package.json
  2. +1 −1 integration/firebase/package.json
  3. +1 −1 integration/firestore/package.json
  4. +1 −1 integration/messaging/package.json
  5. +1 −1 packages/analytics-compat/package.json
  6. +1 −1 packages/analytics/package.json
  7. +1 −1 packages/app-check-compat/package.json
  8. +1 −1 packages/app-check/package.json
  9. +7 −0 packages/app-compat/CHANGELOG.md
  10. +2 −2 packages/app-compat/package.json
  11. +6 −0 packages/app/CHANGELOG.md
  12. +2 −1 packages/app/package.json
  13. +18 −2 packages/app/src/errors.ts
  14. +320 −0 packages/app/src/heartbeatService.test.ts
  15. +290 −0 packages/app/src/heartbeatService.ts
  16. +98 −0 packages/app/src/indexeddb.ts
  17. +6 −0 packages/app/src/internal.ts
  18. +6 −1 packages/app/src/public-types.ts
  19. +8 −0 packages/app/src/registerCoreComponents.ts
  20. +44 −0 packages/app/src/types.ts
  21. +1 −1 packages/auth-compat/package.json
  22. +1 −1 packages/auth/package.json
  23. +1 −1 packages/database-compat/package.json
  24. +1 −1 packages/database/package.json
  25. +10 −0 packages/firebase/CHANGELOG.md
  26. +5 −5 packages/firebase/package.json
  27. +1 −1 packages/firestore-compat/package.json
  28. +2 −2 packages/firestore/package.json
  29. +7 −17 packages/firestore/src/core/target.ts
  30. +31 −4 packages/firestore/src/index/index_entry.ts
  31. +4 −5 packages/firestore/src/local/document_overlay_cache.ts
  32. +2 −3 packages/firestore/src/local/index_manager.ts
  33. +6 −5 packages/firestore/src/local/indexeddb_bundle_cache.ts
  34. +24 −14 packages/firestore/src/local/indexeddb_document_overlay_cache.ts
  35. +440 −36 packages/firestore/src/local/indexeddb_index_manager.ts
  36. +3 −2 packages/firestore/src/local/indexeddb_lru_delegate_impl.ts
  37. +10 −5 packages/firestore/src/local/indexeddb_mutation_batch_impl.ts
  38. +33 −24 packages/firestore/src/local/indexeddb_mutation_queue.ts
  39. +28 −26 packages/firestore/src/local/indexeddb_persistence.ts
  40. +14 −11 packages/firestore/src/local/indexeddb_remote_document_cache.ts
  41. +305 −707 packages/firestore/src/local/indexeddb_schema.ts
  42. +150 −109 packages/firestore/src/local/indexeddb_schema_converter.ts
  43. +395 −0 packages/firestore/src/local/indexeddb_sentinels.ts
  44. +16 −13 packages/firestore/src/local/indexeddb_target_cache.ts
  45. +50 −58 packages/firestore/src/local/local_serializer.ts
  46. +24 −15 packages/firestore/src/local/memory_document_overlay_cache.ts
  47. +3 −8 packages/firestore/src/local/memory_index_manager.ts
  48. +28 −0 packages/firestore/src/local/simple_db.ts
  49. +19 −0 packages/firestore/src/model/collections.ts
  50. +7 −0 packages/firestore/src/model/field_index.ts
  51. +3 −2 packages/firestore/src/model/type_order.ts
  52. +11 −2 packages/firestore/src/model/values.ts
  53. +4 −11 packages/firestore/src/platform/node/base64.ts
  54. +2 −0 packages/firestore/src/util/byte_string.ts
  55. +11 −0 packages/firestore/src/util/obj_map.ts
  56. +1 −1 packages/firestore/src/util/sorted_map.ts
  57. +0 −6 packages/firestore/test/unit/api/bytes.test.ts
  58. +32 −13 packages/firestore/test/unit/local/document_overlay_cache.test.ts
  59. +1,054 −3 packages/firestore/test/unit/local/index_manager.test.ts
  60. +117 −87 packages/firestore/test/unit/local/indexeddb_persistence.test.ts
  61. +20 −25 packages/firestore/test/unit/local/local_serializer.test.ts
  62. +5 −2 packages/firestore/test/unit/local/persistence_transaction.test.ts
  63. +18 −5 packages/firestore/test/unit/local/simple_db.test.ts
  64. +8 −7 packages/firestore/test/unit/local/test_document_overlay_cache.ts
  65. +2 −6 packages/firestore/test/unit/local/test_index_manager.ts
  66. +7 −4 packages/firestore/test/unit/specs/spec_test_runner.ts
  67. +17 −0 packages/firestore/test/unit/util/obj_map.test.ts
  68. +78 −20 packages/firestore/test/unit/util/sorted_map.test.ts
  69. +1 −1 packages/functions-compat/package.json
  70. +1 −1 packages/functions/package.json
  71. +1 −1 packages/installations-compat/package.json
  72. +1 −1 packages/installations/package.json
  73. +7 −0 packages/messaging-compat/CHANGELOG.md
  74. +3 −3 packages/messaging-compat/package.json
  75. +6 −0 packages/messaging/CHANGELOG.md
  76. +2 −2 packages/messaging/package.json
  77. +1 −1 packages/messaging/src/listeners/sw-listeners.ts
  78. +1 −1 packages/performance-compat/package.json
  79. +1 −1 packages/performance/package.json
  80. +1 −1 packages/remote-config-compat/package.json
  81. +1 −1 packages/remote-config/package.json
  82. +1 −1 packages/storage-compat/package.json
  83. +1 −1 packages/storage/package.json
  84. +1 −1 packages/template/package.json
  85. +1 −1 repo-scripts/size-analysis/package.json
8 changes: 4 additions & 4 deletions integration/compat-interop/package.json
View file
Original file line number Diff line number Diff line change
@@ -8,16 +8,16 @@
"test:debug": "karma start --browsers Chrome --auto-watch"
},
"dependencies": {
"@firebase/app": "0.7.17",
"@firebase/app-compat": "0.1.18",
"@firebase/app": "0.7.18",
"@firebase/app-compat": "0.1.19",
"@firebase/analytics": "0.7.5",
"@firebase/analytics-compat": "0.1.6",
"@firebase/auth": "0.19.9",
"@firebase/auth-compat": "0.2.9",
"@firebase/functions": "0.7.8",
"@firebase/functions-compat": "0.1.9",
"@firebase/messaging": "0.9.8",
"@firebase/messaging-compat": "0.1.8",
"@firebase/messaging": "0.9.9",
"@firebase/messaging-compat": "0.1.9",
"@firebase/performance": "0.5.5",
"@firebase/performance-compat": "0.1.5",
"@firebase/remote-config": "0.3.4",
2 changes: 1 addition & 1 deletion integration/firebase/package.json
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
},
"devDependencies": {
"firebase": "9.6.7",
"firebase": "9.6.8",
"@types/chai": "4.2.22",
"@types/mocha": "9.0.0",
"chai": "4.3.4",
2 changes: 1 addition & 1 deletion integration/firestore/package.json
View file
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
"test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
},
"dependencies": {
"@firebase/app": "0.7.17",
"@firebase/app": "0.7.18",
"@firebase/firestore": "3.4.5"
},
"devDependencies": {
2 changes: 1 addition & 1 deletion integration/messaging/package.json
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
"test:manual": "mocha --exit"
},
"devDependencies": {
"firebase": "9.6.7",
"firebase": "9.6.8",
"chai": "4.3.4",
"chromedriver": "94.0.0",
"express": "4.17.1",
2 changes: 1 addition & 1 deletion packages/analytics-compat/package.json
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
"@firebase/app-compat": "0.x"
},
"devDependencies": {
"@firebase/app-compat": "0.1.18",
"@firebase/app-compat": "0.1.19",
"rollup": "2.57.0",
"@rollup/plugin-json": "4.1.0",
"rollup-plugin-typescript2": "0.30.0",
2 changes: 1 addition & 1 deletion packages/analytics/package.json
View file
Original file line number Diff line number Diff line change
@@ -47,7 +47,7 @@
},
"license": "Apache-2.0",
"devDependencies": {
"@firebase/app": "0.7.17",
"@firebase/app": "0.7.18",
"rollup": "2.57.0",
"@rollup/plugin-commonjs": "21.0.0",
"@rollup/plugin-json": "4.1.0",
2 changes: 1 addition & 1 deletion packages/app-check-compat/package.json
View file
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@
},
"license": "Apache-2.0",
"devDependencies": {
"@firebase/app-compat": "0.1.18",
"@firebase/app-compat": "0.1.19",
"rollup": "2.57.0",
"@rollup/plugin-commonjs": "21.0.0",
"@rollup/plugin-json": "4.1.0",
2 changes: 1 addition & 1 deletion packages/app-check/package.json
View file
Original file line number Diff line number Diff line change
@@ -44,7 +44,7 @@
},
"license": "Apache-2.0",
"devDependencies": {
"@firebase/app": "0.7.17",
"@firebase/app": "0.7.18",
"rollup": "2.57.0",
"@rollup/plugin-commonjs": "21.0.0",
"@rollup/plugin-json": "4.1.0",
7 changes: 7 additions & 0 deletions packages/app-compat/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @firebase/app-compat

## 0.1.19

### Patch Changes

- Updated dependencies [[`1588990b7`](https://github.com/firebase/firebase-js-sdk/commit/1588990b7fb06b6fa545c0d478663e137ec0ea07)]:
- @firebase/app@0.7.18

## 0.1.18

### Patch Changes
4 changes: 2 additions & 2 deletions packages/app-compat/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@firebase/app-compat",
"version": "0.1.18",
"version": "0.1.19",
"description": "The primary entrypoint to the Firebase JS SDK",
"author": "Firebase <firebase-support@google.com> (https://firebase.google.com/)",
"main": "dist/index.cjs.js",
@@ -39,7 +39,7 @@
},
"license": "Apache-2.0",
"dependencies": {
"@firebase/app": "0.7.17",
"@firebase/app": "0.7.18",
"@firebase/util": "1.4.3",
"@firebase/logger": "0.3.2",
"@firebase/component": "0.5.10",
6 changes: 6 additions & 0 deletions packages/app/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# @firebase/app

## 0.7.18

### Patch Changes

- [`1588990b7`](https://github.com/firebase/firebase-js-sdk/commit/1588990b7fb06b6fa545c0d478663e137ec0ea07) [#5723](https://github.com/firebase/firebase-js-sdk/pull/5723) - Add heartbeat controller for platform logging.

## 0.7.17

### Patch Changes
3 changes: 2 additions & 1 deletion packages/app/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@firebase/app",
"version": "0.7.17",
"version": "0.7.18",
"description": "The primary entrypoint to the Firebase JS SDK",
"author": "Firebase <firebase-support@google.com> (https://firebase.google.com/)",
"main": "dist/index.cjs.js",
@@ -40,6 +40,7 @@
"@firebase/util": "1.4.3",
"@firebase/logger": "0.3.2",
"@firebase/component": "0.5.10",
"idb": "3.0.2",
"tslib": "^2.1.0"
},
"license": "Apache-2.0",
20 changes: 18 additions & 2 deletions packages/app/src/errors.ts
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,11 @@ export const enum AppError {
DUPLICATE_APP = 'duplicate-app',
APP_DELETED = 'app-deleted',
INVALID_APP_ARGUMENT = 'invalid-app-argument',
INVALID_LOG_ARGUMENT = 'invalid-log-argument'
INVALID_LOG_ARGUMENT = 'invalid-log-argument',
STORAGE_OPEN = 'storage-open',
STORAGE_GET = 'storage-get',
STORAGE_WRITE = 'storage-set',
STORAGE_DELETE = 'storage-delete'
}

const ERRORS: ErrorMap<AppError> = {
@@ -38,7 +42,15 @@ const ERRORS: ErrorMap<AppError> = {
'firebase.{$appName}() takes either no argument or a ' +
'Firebase App instance.',
[AppError.INVALID_LOG_ARGUMENT]:
'First argument to `onLog` must be null or a function.'
'First argument to `onLog` must be null or a function.',
[AppError.STORAGE_OPEN]:
'Error thrown when opening storage. Original error: {$originalErrorMessage}.',
[AppError.STORAGE_GET]:
'Error thrown when reading from storage. Original error: {$originalErrorMessage}.',
[AppError.STORAGE_WRITE]:
'Error thrown when writing to storage. Original error: {$originalErrorMessage}.',
[AppError.STORAGE_DELETE]:
'Error thrown when deleting from storage. Original error: {$originalErrorMessage}.'
};

interface ErrorParams {
@@ -47,6 +59,10 @@ interface ErrorParams {
[AppError.DUPLICATE_APP]: { appName: string };
[AppError.APP_DELETED]: { appName: string };
[AppError.INVALID_APP_ARGUMENT]: { appName: string };
[AppError.STORAGE_OPEN]: { originalErrorMessage?: string };
[AppError.STORAGE_GET]: { originalErrorMessage?: string };
[AppError.STORAGE_WRITE]: { originalErrorMessage?: string };
[AppError.STORAGE_DELETE]: { originalErrorMessage?: string };
}

export const ERROR_FACTORY = new ErrorFactory<AppError, ErrorParams>(
Loading