Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: firebase/firebase-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v12.1.0
Choose a base ref
...
head repository: firebase/firebase-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v12.2.0
Choose a head ref
  • 15 commits
  • 26 files changed
  • 8 contributors

Commits on May 19, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    288d85b View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    fa39e47 View commit details
  3. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f21c068 View commit details

Commits on May 22, 2023

  1. Improve error message when function deployment fails due to quota iss…

    …ues (#5867)
    
    When function deployment fails due to insufficient quota on Cloud Run, the error message is difficult to understand:
    
    ```
    i  functions: creating Node.js 18 function helloWorld(us-east4)...
    ⚠  functions: HTTP Error: 400, Could not create Cloud Run service helloworld. spec.template.spec.containers.resources.limits.cpu: Invalid value specified for cpu. For the specified value, maxScale may not exceed 10.
    Consider running your workload in a region with greater capacity, decreasing your requested cpu-per-instance, or requesting an increase in quota for this region if you are seeing sustained usage near this limit, see https://cloud.google.com/run/quotas. Your project may gain access to further scaling by adding billing information to your account.
    ```
    
    Updated error message, which we hope is clearer and actionable:
    
    ```
    i  functions: creating Node.js 18 (2nd Gen) function helloWorld(us-east4)...
    ⚠  functions: Your current project quotas don't allow for the current max instances setting of 100. Either reduce this function's maxInstances, or request a quota increase on the underlying Cloud Run service at https://cloud.google.com/run/quotas.
    ⚠  functions: You can adjust the max instances value in your function's runtime options:
    	setGlobalOptions({maxInstances: 10})
    ```
    taeold authored May 22, 2023
    Copy the full SHA
    528aedd View commit details
  2. RTDB emulator 4.11.2 (#5863)

    fredzqm authored May 22, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    03b3ad2 View commit details
  3. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    cfb94a2 View commit details
  4. Revert "Improve cleanup process when reloading emulated functions in …

    …debug mode."
    
    This reverts commit cfb94a2.
    taeold committed May 22, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e40b297 View commit details
  5. Nuxt, baseURL, and SSG fixes (#5716)

    * Handle Nuxt bundled dependencies
    * Add fast dev-mode to Nuxt 2
    * Handle ssr true/false in Nuxt apps in a more conventional way
    * Import all the integrations, rather than dynamically require
    * Leave it to the framework to rewrite as an SPA
    * Handle Nuxt3 baseURL
    * SPAs for Nuxt3 and Angular now respect baseUrl
    * If the Nuxt version couldn't be determined, assume Nuxt v3
    * Nuxt used process.cwd in a couple places, guard against this
    * Allow for Angular apps leveraging serveOptimizedImages to still be treated as an SPA
    jamesdaniels authored May 22, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    bea955f View commit details

Commits on May 23, 2023

  1. FIREBASE_FRAMEWORKS_BUILD_TARGET (#5572)

    Co-authored-by: James Daniels <jamesdaniels@google.com>
    chalosalvador and jamesdaniels authored May 23, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    5c7fa9f View commit details
  2. Tweaking some text string formatting as a follow-up to PR 5867. (#5876)

    * Tweaking some text string formatting as a follow-up to PR 5867.
    
    * Removing stray backtick.
    
    * Platform agnosticizing our usage of 'max instances.'
    egilmorez authored May 23, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7ed62f3 View commit details
  3. Fix Vite js-sdk auto init (#5610)

    Co-authored-by: James Daniels <jamesdaniels@google.com>
    chalosalvador and jamesdaniels authored May 23, 2023
    Copy the full SHA
    a6657df View commit details
  4. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    4c5d8c9 View commit details
  5. Improves cleanup process when reloading emulated functions in debug m…

    …ode. (#5878)
    
    Instead of spawning a new process that exposes the debugger endpoint, the Functions Emulator will attempt to explicitly kill the existing process before loading the function with the updated source code.
    
    Possible fix for #5508, #5653.
    taeold authored May 23, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7909fc6 View commit details
  6. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    cbd92e8 View commit details
  7. 12.2.0

    google-oss-bot committed May 23, 2023
    Copy the full SHA
    5c03bf5 View commit details
Loading