Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: firebase/firebase-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v12.4.0
Choose a base ref
...
head repository: firebase/firebase-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v12.4.1
Choose a head ref

Commits on Jun 15, 2023

  1. Copy the full SHA
    3f3c186 View commit details

Commits on Jun 16, 2023

  1. Auth integration (#5667)

    * plugin integration WIP
    
    * add getInitFirebaseResponse type
    
    * satisfy tsconfig.compile.json
    
    * update get-init-firebase-response response format
    
    * isMonospaceEnv
    
    * set access token only in autoAuth
    
    * get monospace daemon port in function
    
    * create `.firebaserc` with authorized project
    
    * don't run setupMonospace if is vs code extension
    
    * return authorized project
    
    * isVSCE from options, return null if no project
    
    * clean up
    
    * use `projectRoot` again, only create rc if ...
    ... there's a project
    
    * lint friendly assertion
    
    * `/get-init-firebase-response` responses in logger
    
    * handle `userResponse` false
    
    * address nit, replace FIXME with TODO
    
    * depromisify isMonospaceEnv
    
    * remove unnecessary else
    
    * poll every 2 seconds instead of 5
    leoortizz authored Jun 16, 2023
    Copy the full SHA
    71c8e7d View commit details
  2. Fix flaky convertConfig test (#5981)

    * Increasing timeout on flaking unit tests
    
    * take 2
    
    * Increasing timeouts further
    
    * Found the actual cause - flaky tests were making remote calls and catching 403 errors
    
    * formats
    joehan authored Jun 16, 2023
    Copy the full SHA
    ba8a2a3 View commit details
  3. Copy the full SHA
    4b28e8a View commit details

Commits on Jun 17, 2023

  1. Emulators in the VSCode plugin (#5954)

    Add emulator support in the VSCode plugin. This is still a prototype version and you may encounter bugs.
    christhompsongoogle authored Jun 17, 2023
    Copy the full SHA
    4612ef2 View commit details

Commits on Jun 20, 2023

  1. Copy the full SHA
    17eb321 View commit details
  2. Run lifecycle hooks for specific codebases (#6011)

    * run lifecycle hooks for codebases specified by only
    
    * update changelog
    blidd-google authored Jun 20, 2023
    Copy the full SHA
    c552816 View commit details

Commits on Jun 21, 2023

  1. Fixed a bug in the hosting config for emulators. (#6013)

    Also fixed an issue where an empty folder creates an issue loading the side panel.
    christhompsongoogle authored Jun 21, 2023
    Copy the full SHA
    b1b513b View commit details
  2. Copy the full SHA
    0561d36 View commit details
  3. Missed a few changes from comments (#6015)

    * Fixed a bug in the hosting config for emulators. Also fixed an issue
    where an empty folder creates an issue loading the side panel.
    
    * Missed some changes
    
    * Update firebase-vscode/webviews/components/EmulatorPanel.tsx
    
    Co-authored-by: joehan <joehanley@google.com>
    
    ---------
    
    Co-authored-by: joehan <joehanley@google.com>
    christhompsongoogle and joehan authored Jun 21, 2023
    Copy the full SHA
    58c7c65 View commit details

Commits on Jun 22, 2023

  1. Fix firebase emulators:start crashing (#6005)

    * Update proxyResponse method
    
    * Add proper types to proxyResponse function
    
    * Changelog
    
    * Changelog formatting
    
    * Update CHANGELOG.md
    
    * Update firebase-vscode/package-lock.json
    
    ---------
    
    Co-authored-by: joehan <joehanley@google.com>
    chalosalvador and joehan authored Jun 22, 2023
    Copy the full SHA
    05c3013 View commit details
  2. Copy the full SHA
    8530334 View commit details
  3. Init flow frameworks cli. (#6010)

    * Added init flow commands
    
    * change region name
    
    * Enable frameworkstacks api
    
    * Added code review changes
    
    * Revert unwanted changes
    
    * Revert unwanted changes
    
    * Revert unwanted changes
    
    * change according to project id
    
    * Removed unwanted statements related to projectId
    svnsairam authored Jun 22, 2023
    Copy the full SHA
    87968f0 View commit details
  4. Frameworks (#6012)

    * Initial commit to stacks api
    
    * Added more properties to the Stack and Build object
    
    * Added api calls for framework stacks
    
    * Changed naming
    
    * Changed naming
    
    * Review changes
    
    * Removed and used minimal fields
    
    * Moved frameworks api file
    svnsairam authored Jun 22, 2023
    Copy the full SHA
    9330b35 View commit details
  5. Switched most uses of track to GA4 (#6016)

    * Switched most uses of track to GA4
    
    * Move duration out of params, and improve debug logging slightly
    joehan authored Jun 22, 2023
    Copy the full SHA
    728d07d View commit details

Commits on Jun 23, 2023

  1. Release Firestore emulator 1.18.1 (#5942)

    * Release Firestore emulator 1.18.1
    
    * Update CHANGELOG.md
    
    Co-authored-by: joehan <joehanley@google.com>
    
    * Formatting changes in CHANGE.md
    
    * Update CHANGELOG.md
    
    ---------
    
    Co-authored-by: Jia You <jiayou@google.com>
    Co-authored-by: joehan <joehanley@google.com>
    Co-authored-by: christhompsongoogle <106194718+christhompsongoogle@users.noreply.github.com>
    4 people authored Jun 23, 2023
    Copy the full SHA
    a9b6ecf View commit details
  2. Copy the full SHA
    29747a8 View commit details
  3. Inject GOOGLE_CLOUD_QUOTA_PROJECT environment variable during functio…

    …n discovery and emulation (#5985)
    
    When deploying functions that makes use of GCP's usage-based (not resource-based) APIs , such as Vertex AI or ML Vision API, users may see an error like this:
    
    
    ```
    // main.py
    import vertexai
    # Initialize the Vertex AI client
    vertexai.init()
    
    $ firebase deploy
    Failed to load function definition from source: FirebaseError: Failed to parse build specification
    
    Caused by:
    403 Vertex AI API has not been used in project 563584335869 before or it is disabled. 
    ```
    
    During function discovery, `vertex.init()` makes a call to the Vertex AI with the client credentials associated with Firebase CLI . In the case of usage-based APIs, the call is being made on the Firebase CLI project, not the users project, resulting in the error message like `been used in project 563584335869 before or it is disabled.` (project `563584335869` is the Firebase CLI GCP project).
    
    Similar issue happens when running the function on the emulator.
    
    To workaround the issue, we have to properly override the client project associated with the Vertex AI API call. There are few ways for doing this, and here we choose to leverage `GOOGLE_CLOUD_QUOTA_PROJECT` environment variable to correctly override the quota project to be the user project associated with the Firebase CLI session.
    taeold authored Jun 23, 2023
    Copy the full SHA
    d971a08 View commit details
  4. Reimplement Storage emulator /internal/setRules (#6014)

    * stash
    
    * commit
    
    * commit
    
    * lint
    
    * fix tests
    
    * const
    tonyjhuang authored Jun 23, 2023
    Copy the full SHA
    463e649 View commit details
  5. Adding JSON schema for extension yaml (#5984)

    * Starting on extension.yaml json schema
    
    * finsh extension.yaml schema
    
    * adding events
    
    * add billingrequired
    
    * Adding schemas to vscode plugin too
    
    * reverting new format for firebase-config.json
    joehan authored Jun 23, 2023
    Copy the full SHA
    8af4c93 View commit details
  6. Copy the full SHA
    34f4d95 View commit details

Commits on Jun 26, 2023

  1. Print functions discovery to stdout/error (#5931)

    * Print functions discovery to stdout/error
    
    * More tweaking
    
    * lint fixes
    
    * Use logger instead of console to work with --json
    
    ---------
    
    Co-authored-by: Daniel Lee <danielylee@google.com>
    inlined and taeold authored Jun 26, 2023
    Copy the full SHA
    f6ed7b6 View commit details
  2. Bump firebase-frameworks version in constants.ts (#6038)

    Fixes compatibility with latest Next.js
    alexastrum authored Jun 26, 2023
    Copy the full SHA
    380390f View commit details
  3. Copy the full SHA
    2b18e0b View commit details
  4. Fix table in CONTRIBUTING.md (#6029)

    Multi-line table syntax is not supported in GitHub Markdown.
    alexastrum authored Jun 26, 2023
    Copy the full SHA
    af7c645 View commit details

Commits on Jun 27, 2023

  1. Implement module to link stack to GitHub repository (#5793)

    * add internal testing cmd for connecting gh to cloud build repos
    
    * use regex to extract repo slug
    
    * add comments
    
    * add unit tests
    
    * fix tests
    
    * refactoring & allow changing gh app access settings
    
    * refactor & update unit tests
    
    * add comments & change internaltesting name
    
    * rename to composer
    blidd-google authored Jun 27, 2023
    Copy the full SHA
    31c2d22 View commit details
  2. Imporved extensions metrics (#6037)

    * Switched most uses of track to GA4
    
    * Move duration out of params, and improve debug logging slightly
    
    * Improved metrics for extensions
    
    * formats
    joehan authored Jun 27, 2023
    Copy the full SHA
    e96b069 View commit details
  3. 12.4.1

    google-oss-bot committed Jun 27, 2023
    Copy the full SHA
    3ca530c View commit details
Loading