Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty namespaces are not exported on exit #2634

Closed
quantuminformation opened this issue Sep 21, 2020 · 6 comments · Fixed by #2648
Closed

Empty namespaces are not exported on exit #2634

quantuminformation opened this issue Sep 21, 2020 · 6 comments · Fixed by #2648
Assignees

Comments

@quantuminformation
Copy link

If I click delete on the root node the data is removed in the browser.

image

Im using RUNNING_LOCAL=true firebase emulators:start --only database,functions --inspect-functions --import=./seed --export-on-exit

however if I close the terminal and restart all data is still there. The only way I can remove the data on restart is to delete the seed file.

@malcolmdeck
Copy link
Contributor

Hey there,

Thanks for the report. It sounds like this is working-as-intended - --export-on-exit does not overwrite the seed file. It sounds like you'd like for an option that makes whatever the emulator state is at exit to be what it is at startup. I've filed b/169081327 as an internal feature request.

Thanks,
~Malcolm

@quantuminformation
Copy link
Author

Ah, so when does the seed file get populated?

@samtstern
Copy link
Contributor

Actually I think it is supposed to update the seed file ... will look into this.

@samtstern samtstern self-assigned this Sep 23, 2020
@samtstern
Copy link
Contributor

But this should be on firebase-tools

@samtstern samtstern transferred this issue from firebase/firebase-tools-ui Sep 23, 2020
@samtstern
Copy link
Contributor

@quantuminformation ok so I think I know what's happening! When we do the export we ignore any "empty" namespaces, which are databases that have no data. The reason for this is that sometimes during testing (especially with @firebase/testing) people create many databases that they don't want exported.

I think what we need to do is remember which namespaces were imported and then make sure to always export those, even if they're empty at the end.

@quantuminformation
Copy link
Author

sorry for more work for you guys!

thx

@samtstern samtstern changed the title Unable to clear the data from the UI Empty namespaces are not exported on exit Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants