Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yml file writes in firebase init hosting:github #2688

Merged
merged 4 commits into from Oct 9, 2020

Conversation

jhuleatt
Copy link
Contributor

@jhuleatt jhuleatt commented Oct 9, 2020

Description

Fixes bugs in the firebase hosting init:github command where:

  • The firebase-hosting-pull-request.yml file was written to the wrong location even though the CLI logged the correct location
  • The firebase-hosting-merge.yml file was never written

Scenarios Tested

  • firebase init hosting:github, answered "no" to "Set up automatic deployment to your site's live channel when a PR is merged?"
  • firebase init hosting:github, answered "yes" to "Set up automatic deployment to your site's live channel when a PR is merged?"
>firebase init hosting:github 
// ...
=== Hosting:github Setup

i  Detected a .git folder at /Users/jhuleatt/git/how-cool-is-this
i  Authorizing with GitHub to upload your service account to a GitHub repository's secrets store.

Visit this URL on this device to log in:
<REDACTED/>

Waiting for authentication...

✔  Success! Logged into GitHub as jhuleatt

? For which GitHub repository would you like to set up a GitHub workflow? jhuleatt/super-duper-happiness

✔  Created service account <REDACTED/> with Firebase Hosting admin permissions.
✔  Uploaded service account JSON to GitHub as secret FIREBASE_SERVICE_ACCOUNT_ACTION_HOSTING_DEPLOY_DEMO.
i  You can manage your secrets at <REDACTED/>.

? Set up the workflow to run a build script before every deploy? Yes
? What script should be run before every deploy? npm ci && npm run build

✔  Created workflow file /Users/jhuleatt/git/how-cool-is-this/.github/workflows/firebase-hosting-pull-request.yml
? Set up automatic deployment to your site's live channel when a PR is merged? Yes
? What is the name of the GitHub branch associated with your site's live channel? master

✔  Created workflow file /Users/jhuleatt/git/how-cool-is-this/.github/workflows/firebase-hosting-merge.yml

i  Action required: Visit this URL to revoke authorization for the Firebase CLI GitHub OAuth App:
<REDACTED/>
i  Action required: Push any new workflow file(s) to your repo

i  Writing configuration info to firebase.json...
i  Writing project information to .firebaserc...

✔  Firebase initialization complete!

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Oct 9, 2020
Copy link

@henrypbriffel henrypbriffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where A&Tsync

@jhuleatt jhuleatt requested a review from bkendall October 9, 2020 23:08
Copy link
Contributor

@mbleigh mbleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a CHANGELOG.md please?

@jhuleatt
Copy link
Contributor Author

jhuleatt commented Oct 9, 2020

Added CHANGELOG.md entry - I think I added it in the right spot?

@mbleigh
Copy link
Contributor

mbleigh commented Oct 9, 2020

yup, lgtm

@jhuleatt jhuleatt removed the request for review from bkendall October 9, 2020 23:19
@jhuleatt jhuleatt merged commit e3f08ff into master Oct 9, 2020
@bkendall bkendall deleted the jhuleatt-fix-yaml-path branch August 4, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants